Bug 145114 - TEMPLATES: Improve confirmation dialog "Update styles / Keep Old Styles" dialog + If the template has been detached, it is still specified in "File > Properties > General"
Summary: TEMPLATES: Improve confirmation dialog "Update styles / Keep Old Styles" dial...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.5.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: easyHack, skillCpp, skillUI
Depends on:
Blocks: Templates File-Properties
  Show dependency treegraph
 
Reported: 2021-10-13 15:02 UTC by larson
Modified: 2022-01-09 03:39 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description larson 2021-10-13 15:02:14 UTC
Description:
When you open a document which is based on the template that has been changed since the last time you saved the document, there will be a message like this one:

```
The template 'Foo' on which this document is based, has been modified. Do you want to update style based formatting according to the modified template?

Update Styles / Keep Old Styles
```

There are three problems.

1. The first problem is that if you select "Keep Old Styles", this will in fact detach the template from the document, so that you won't receive the same message "The template 'Foo' on which this document is based, has been modified..." so you never again see such a message for this document, even if you change the template again.

Possible solutions:

* To rename the "Keep Old Styles" button to something that sounds more scary.
* To add an option under "Tools > Options" to never show this dialog window and instead apply "Update Styles" choice silently.
* To provide an option to reattach a detached template.

2. The second problem that if you select "Keep Old Styles" and then open "File > Properties > General", the field "Template" still have "Foo" as its value ("Foo" is the name of your template). I think this is simply not true, since the template has been detached. And of course this is confusing.

Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Dieter 2021-10-30 06:54:26 UTC
(In reply to larson from comment #0)
> 1. The first problem is that if you select "Keep Old Styles", this will in
> fact detach the template from the document, so that you won't receive the
> same message "The template 'Foo' on which this document is based, has been
> modified..." so you never again see such a message for this document, even
> if you change the template again.

I confirm the problem and I wasn't aware, that LO behaves like this.

> 
> Possible solutions:
> 
> * To rename the "Keep Old Styles" button to something that sounds more scary.
> * To add an option under "Tools > Options" to never show this dialog window
> and instead apply "Update Styles" choice silently.
> * To provide an option to reattach a detached template.
I would at least expect tooltips in the dialog and a help button (but I think also help page is missing

> 
> 2. The second problem that if you select "Keep Old Styles" and then open
> "File > Properties > General", the field "Template" still have "Foo" as its
> value ("Foo" is the name of your template). I think this is simply not true,
> since the template has been detached. And of course this is confusing.

I confirm this problem, too. Possible solution: "Foo (not actualized)" (or something similar)

cc: Desing-Team for further input and decision. It might be useful to split nto two reports, but let's wait until desgn-team says, both are valid issues.
Comment 2 Heiko Tietze 2021-11-08 12:03:37 UTC
Does "~Keep Old Styles (and detach template)" work better? Would be include/sfx2/strings.hrc STR_QRYTEMPL_KEEP_BTN.

If the template is detached we should update the properties dialog accordingly. Could be an easyhack in sfx2/source/dialog/dinfdlg.cxx
Comment 3 Dieter 2021-11-08 13:30:35 UTC
(In reply to Heiko Tietze from comment #2)
> Does "~Keep Old Styles (and detach template)" work better? Would be
> include/sfx2/strings.hrc STR_QRYTEMPL_KEEP_BTN.
Yes, much better than actual behaviour. What do you think about tooltip or helppage, Heiko.
 
> If the template is detached we should update the properties dialog
> accordingly. Could be an easyhack in sfx2/source/dialog/dinfdlg.cxx
I agree.
Comment 4 Heiko Tietze 2021-11-11 15:01:59 UTC
No further input, let's do it.