Bug 145161 - Image compression dialog is misleadingly labelled: doesn't always "reduce image resolution" (comment 9)
Summary: Image compression dialog is misleadingly labelled: doesn't always "reduce ima...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Image-Compression-Dialog
  Show dependency treegraph
 
Reported: 2021-10-15 19:57 UTC by Jérôme
Modified: 2023-04-20 09:37 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme 2021-10-15 19:57:02 UTC
The image compression form will save the new image with the target resolution even if the former image has a lower resolution that the target. This generally increases the image file size.
Comment 1 Timur 2021-10-16 05:41:56 UTC
You filed bug 145160 and bug 145161 probably without searching existing bugs first. Please do and see if a duplicate, maybe bug 132592.
Comment 2 Jérôme 2021-10-16 08:31:20 UTC
(In reply to Timur from comment #1)

This bug isn't a duplicate of bug 132592 since it focuses on a specific issue.

Bug 132592 is a set of different issues. Each issue of bug 132592 could be addressed by a different team and a specific timeline.
Comment 3 Jérôme 2021-10-17 16:41:36 UTC
See bug 77407 comment 9.
Comment 4 Buovjaga 2022-12-05 16:54:23 UTC
(In reply to Jérôme from comment #0)
> The image compression form will save the new image with the target
> resolution even if the former image has a lower resolution that the target.
> This generally increases the image file size.

UX team: are we taking away a legitimate use case, if this is restricted?
Comment 5 Heiko Tietze 2022-12-06 13:50:40 UTC
What do you expect from (any) tool if the source is 10ppi and you "compress" to 500ppi? Probably that increasing the size is not possible per maximum value.
Comment 6 Jérôme 2022-12-09 20:42:55 UTC
Version: 7.4.3.2 / LibreOffice Community
Build ID: 8d7af0b9f05ca3f6bf3593323f061d3291e2ce28
CPU threads: 4; OS: Linux 4.9; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.utf8); UI: fr-FR
Calc: threaded

With this version, let's create a document (Writer or Impress) and insert an image which appears in ~300 dpi (jpeg 404 KiB in my example).

Then go to the contextual menu on the image and select "compress".

If you select the "reduce image resolution to:" checkbox and the 600 dpi resolution and press the "ok" button. Then you get a 600 dpi image (jpeg 1165 KiB in my example).

My point is that the words "reduce image resolution to" are wrong. If it were reduced, the original image would at least remain intact.
Comment 7 Jérôme 2022-12-10 13:28:13 UTC
> My point is that the words "reduce image resolution to" are wrong. If it
> were reduced, the original image would at least remain intact.

I propose that we keep the words "reduce image resolution to" and adjust the behaviour of this dialog : change the resolution of the image only if its resolution is reduced.

Example A :
1. original image is 250 dpi
2. select 300 dpi and click ok keep the original image intact

Exemple B :
1. original image is 250 dpi
2. select 150 dpi and click ok reduce the resolution of the image

Exemple C :
1. original image is 250 dpi
2. select 100 dpi and click ok reduce the resolution of the image


There is an additional feature (proposed in https://bugs.documentfoundation.org/show_bug.cgi?id=77407#c9 ) : make the example B keep the original image intact (since [original resolution] < 2 * [target resolution]).
Comment 8 Heiko Tietze 2022-12-12 09:16:24 UTC
(In reply to Jérôme from comment #7)
> Example A :
> 1. original image is 250 dpi
> 2. select 300 dpi and click ok keep the original image intact

Meaning you can configure something in the dialog and it has just no effect (nor feedback).

What I meant with maximum in comment 5 is to omit 600dpi in the dropdown list if the image has 300dpi. Could also be realized as slider with steps from min to max. But the point is: Do we really need to change this? Just to be consistent with the usual wording.
Comment 9 Heiko Tietze 2022-12-16 07:59:42 UTC
We discussed the topic in the design meeting.

While I commented before that limiting the resolution to the source dpi could be done it's not possible since we also allow to change width/height (or we set a maximum here too). And changing the image size affects the resolution (whether this is necessary is a different question).

So it's actually just the label that doesn't fit the current situation. And we propose to change it to "Change image resolution to:".

We also pondered quickly over the dialog title (and command name) "Compress Image" but better keep this familiar term.

Code pointer: svx/uiconfig/ui/compressgraphicdialog.ui

This ticket kind of duplicates bug 132657, up to QA.
Comment 10 Stéphane Guillou (stragu) 2022-12-16 18:24:27 UTC
(In reply to Heiko Tietze from comment #9)

> This ticket kind of duplicates bug 132657, up to QA.

Seeing the UX recommendations, let's keep this ticket as the relabelling easyHack. Changing summary accordingly.

Bug 132657 can continue the discussion around potential deeper changes, regarding size / resolution limits, syncing of values, etc.