Created attachment 175894 [details] Extrusion and Fontwork examples In a drop-down list of a toolbar, which has icon/button and label, it is no longer possible to activate the item by clicking on the label. That is not only inconvenient, but makes settings unreachable. Open attached document. It contains a custom shape in extruded mode and a Fontwork shape. Click the extruded custom shape. From the "3D Effects" toolbar open the drop-down list "Depth". Click on "Customize" to change the depth. After the shape has got a customized depth, it is not possible to change the value because neither a click on the radio button nor a click on the label opens the "Customize" dialog. The same error is with the Fontwork shape. Click on the Fontwork shape. From the "Fontwork" toolbar open the drop-down list "Fontwork Character Spacing". Click on "Customize" to change the spacing. The dialog does not open. It fails at least since Version: 7.2.0.0.beta1 (x64) / LibreOffice Community Build ID: c6974f7afec4cd5195617ae48c6ef9aacfe85ddd CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL It is OK in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 42e0ea0a6e4f48967d58fa95081c8ba5a6b08bc6 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
Confirmed. Can't select an action on these Toolbar buttons via their label. Version: 7.2.2.2 (x64) / LibreOffice Community Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Only the button with icon selection performs the action. Workaround for the dialogs linked to the radiobutton is to select another value, then the dialog is again exposed with the custom RB.
@Caolán -- maybe related to the "toggle instead of click" work? https://gerrit.libreoffice.org/c/core/+/115821 https://gerrit.libreoffice.org/c/core/+/115852
Yeah for gtk4 checkbuttons/radiobuttons aren't "buttons" anymore and don't have a "clicked" hence that change. I'll have to reimagine these two cases in terms of something "clickable"
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/592235d64d6f9638a61865712ca385ec58d688c4 tdf#145296 use a 'clickable' widget for custom depth It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/312a32f6b6c83c5747b617249d794fc87ffd8b9b tdf#145296 use a 'clickable' widget for custom spacing It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9142f66ec1c78292dd2b8863c622dfb705dd2db2 Related: tdf#145296 we have spacing images we can reuse here It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The two Customize items work now in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ca74611acfef50280a2c1f785448d9a09cca5a0d CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL The appearance of the drop-down list is not good. It is different from the other drop-down lists and the labels are not left aligned but centered. Why were these drop-down lists changed at all? They worked fine in previous versions, at least on Windows.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/49433bb67d8602898cdeaed87eb0ebfa4ec3058f Related: tdf#145296 use last spacing value as default for custom It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Alignment can be fixed easily enough. The changes are because of the attempt to migrate away from using the vcl toolkit for the gtk port to using the gtk toolkit (theming the vcl toolkit to look like the gtk one became difficult by gtk3 and in gtk4 I don't think its practical to even attempt it). In gtk4 there will be additional changes mentioned in #3 where there isn't a click signal anymore in the (real) GtkRadioButtons used like there was in gtk3 so there's only signals for toggled on/off. We get caught in these little weird use edge cases like wanting to know if a toggled on radiobutton is clicked. All that said, I think I can try an alternative approach here which will likely be more appealing.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aa7e489533a82135272576e06492631d8a9e3c66 tdf#145296 better fix to launch dialog when active radiobutton is clicked It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This should be more appealing as it should appear and function the same as the original. Backport to 7-2 in gerrit.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/37147e03918ed73c34e5a63bf775c98f0b9238ec tdf#145296 better fix to launch dialog when active radiobutton is clicked It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.