Bug 145386 - bogus lang-tag in status bar language selector
Summary: bogus lang-tag in status bar language selector
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Eike Rathke
URL:
Whiteboard: target:7.3.0 target:7.2.5
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-29 19:32 UTC by Michael Meeks
Modified: 2021-12-06 13:28 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
a document (9.50 KB, application/msword)
2021-10-29 19:32 UTC, Michael Meeks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2021-10-29 19:32:57 UTC
Created attachment 176010 [details]
a document

Loading this simple document - I get a language in the status bar of: English (United Kingdom){en-GB} which is unexpected and looks odd.
Comment 1 Eike Rathke 2021-11-07 18:18:03 UTC
So I dug deeper into this than anticipated.. Writer has no handling of the LCID 0x0400 LANGUAGE_PROCESS_OR_USER_DEFAULT language/locale concept, in fact it also explicitly doesn't expect our LANGUAGE_SYSTEM locale assigned as character attribution. The status bar is just a cosmetic symptom, the same "{en-GB}" or in 7.3 "English (United Kingdom) {en-GB}" string is displayed in the status bar menu and in the character/paragraph font attribution language list, worse, it appears in both Western and CJK lists.

Coming up with a tentative fix for the language/locale display.
Comment 2 Commit Notification 2021-11-07 19:12:25 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0f3c19ee61ec371aa32d9f51c3555d3ea8ae9eeb

Resolves: tdf#145386 Use "Default" for LANGUAGE_PROCESS_OR_USER_DEFAULT

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Eike Rathke 2021-11-07 22:01:09 UTC
Pending review https://gerrit.libreoffice.org/c/core/+/124204 for 7-2
Comment 4 Commit Notification 2021-11-08 09:03:39 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/4e2c807f89fe8156f7b803c4de6e932bb9c340d2

Resolves: tdf#145386 Use "Default" for LANGUAGE_PROCESS_OR_USER_DEFAULT

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Michael Meeks 2021-11-08 09:19:52 UTC
Thanks Eike ! sorry it turned out to be more problematic than expected.
Comment 6 Christian Lohmaier 2021-12-06 13:28:48 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard