Bug 145517 - Reduce overload of term "style" in Options > View
Summary: Reduce overload of term "style" in Options > View
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium trivial
Assignee: Adolfo Jayme Barrientos
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks:
 
Reported: 2021-11-03 01:04 UTC by Adolfo Jayme Barrientos
Modified: 2022-01-21 11:24 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adolfo Jayme Barrientos 2021-11-03 01:04:45 UTC 
"Icon style" should be "icon theme", as everybody calls it, both within this project and elsewhere.
Comment 1 V Stuart Foote 2021-11-03 13:14:04 UTC 
+1
Comment 2 Heiko Tietze 2021-11-10 08:48:13 UTC 
The label is in cui/uiconfig/ui/optviewpage.ui

We have "Icon Style" twice, on the frame and in front of the dropdown. My take: keep the frame label and rename the dropdown label to "Theme:" or "Icon theme:". Or use "Icon Theme" on the frame and just "Name:" below.
Comment 3 Adolfo Jayme Barrientos 2021-12-15 11:12:07 UTC 
Agreed with reducing the second label to the minimum: right now, it’s effectively duplicated.
Comment 4 Commit Notification 2022-01-21 11:15:49 UTC 
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9f16c3b5ac3ae1c9d24fe137ff48b67f54e4899b

tdf#145517 Reduce overload of term “style” in Options > LO > View

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-01-21 11:24:00 UTC 
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/66dc0fd6708f70b931f189d63ef140de7114dfa1

tdf#145517 Change “Icon Style” to “Icon Theme”