There are several string literals in the header files, defined in various ways like const char[]. You should convert string literals in header files from "const char[]" to "constexpr OUStringLiteral". Instances of the literals defined as "const char[]" can be found using: git grep "^const char" *.hxx|grep -F [ A sample can be found here: https://git.libreoffice.org/core/+/8fb366c13ac1b23c455c32afc085bca2edff03bb
I pushed a patch to gerrit: https://gerrit.libreoffice.org/c/core/+/124724 Please review it :-)
Jeff Huang committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7b0e0409c3f24dfe37d9c43ffa439b56ea719868 tdf#145539 const OUString -> constexpr OUStringLiteral It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
When I use 'git grep "^const char" *.hxx| grep -F [', I can only find this place, so this issue should be closed when 7.3.0 is out I think?
(In reply to Po-Yen Huang from comment #3) > When I use 'git grep "^const char" *.hxx| grep -F [', I can only find this > place, so this issue should be closed when 7.3.0 is out I think? Should this issue be closed as RESOLVED FIXED now ?
(In reply to Xisco Faulí from comment #4) > (In reply to Po-Yen Huang from comment #3) > > When I use 'git grep "^const char" *.hxx| grep -F [', I can only find this > > place, so this issue should be closed when 7.3.0 is out I think? > > Should this issue be closed as RESOLVED FIXED now ? I think yes, if no other one find another string for this.
What about all the ones where const char is not immediately at the beginning of the line: git grep "const char" *.hxx| grep -F [
(In reply to Buovjaga from comment #6) > What about all the ones where const char is not immediately at the beginning > of the line: > > git grep "const char" *.hxx| grep -F [ Ah yeah, there are some strings when using this command, should they be all replaced?
(In reply to Po-Yen Huang from comment #7) > (In reply to Buovjaga from comment #6) > > What about all the ones where const char is not immediately at the beginning > > of the line: > > > > git grep "const char" *.hxx| grep -F [ > > Ah yeah, there are some strings when using this command, should they be all > replaced? Let's wait for Hossein's opinion (he comes back in a couple of days)