Bug 145625 - In Options – LibreOffice – Application Colors, the "On" label isn’t aligned with the checkboxes below
Summary: In Options – LibreOffice – Application Colors, the "On" label isn’t aligned w...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3 all versions
Hardware: All All
: medium minor
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-11 07:55 UTC by Kees Kriek
Modified: 2022-01-26 15:30 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
screen shot of the bug (57.49 KB, application/vnd.oasis.opendocument.graphics)
2021-11-11 07:57 UTC, Kees Kriek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kees Kriek 2021-11-11 07:55:53 UTC
Description:
In Options – LibreOffice – Application Colors, the part User interface elements has two Key-id codes.
Because of that the word ”On” appears before the name.
See attachment for more details.

Steps to Reproduce:
1.Go to Tools - LibreOffice - Application Colors
2.
3.

Actual Results:
The part is called "On  User interface elements"

Expected Results:
It should be called "User interface elements" without "On"


Reproducible: Always


User Profile Reset: Yes



Additional Info:
The Key-id code s9Q, that generates the "On", should not be there.

Version: 7.2.2.2 (x64) / LibreOffice Community
Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56
CPU threads: 8; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: threaded
Comment 1 Kees Kriek 2021-11-11 07:57:53 UTC
Created attachment 176185 [details]
screen shot of the bug
Comment 2 Ming Hua 2021-11-11 08:24:39 UTC
As far as I understand, the "On" is a separate string, meant as the header of the checkboxes below.  Whether it is a good UI decision is a good question, but it's natural for a string to have its own KeyID.

And the KeyID is not s9Q, but Jms9Q [1], you are just seeing it truncated.

1. https://translations.documentfoundation.org/translate/libo_ui-master/cuimessages/en/?checksum=f123e315ec047d8c
Comment 3 Kees Kriek 2021-11-11 08:45:15 UTC
The Key-id is indeed Jms9Q but the screen only shows s9Q.
To me, it seems "On" is out of place.
I can not see how it can be the header of the checkboxes below.
Comment 4 Kees Kriek 2021-11-11 08:48:23 UTC
I see it now.
There is a column of checkboxes below.
It still is a bit confusing that the word 'Ön" is above them.
I do not see a construction like this in other places where there are also checkboxes.
Comment 5 Ming Hua 2021-11-11 09:07:38 UTC
(In reply to kees538 from comment #4)
> It still is a bit confusing that the word 'Ön" is above them.
I agree.  Like I said, I question whether this is good UI design.

I was just saying this has nothing to do with KeyID or anything translation related.  It's a simple UI element, although an odd and maybe confusing one.

Maybe we can change this bug to be about changing or getting rid of this "On" string, and ask UX team for their opinions.
Comment 6 Kees Kriek 2021-11-11 09:14:08 UTC
Sorry, I misunderstood.
That seems like a good idea to me.
Comment 7 Adolfo Jayme Barrientos 2021-11-17 10:03:47 UTC
I don’t agree with the premise of this report. The problem is not that the word “On” is used — the actual problem is that the headers aren’t aligned with the checkboxes below.
Comment 8 Heiko Tietze 2021-11-17 11:06:08 UTC
(In reply to Adolfo Jayme from comment #7)
> ...the headers aren’t aligned with the checkboxes below.

No problem with kf5/gen and win but gtk3 (would also be an issue if we clear the label).
Comment 9 Heiko Tietze 2021-11-18 14:48:19 UTC
Topic was on the agenda but didn't receive further comments. So let's remove the label "On" and fix the alignment issue.
Comment 10 Commit Notification 2022-01-13 07:23:26 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8d2bf9b679dec223a78e1fd8f3684f76c5802bae

Resolves tdf#145625 - Alignment issue at color options

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-01-13 14:47:52 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f041e3153fee98aa708edcd9071ea58fdde052b

Related: tdf#145625 adapt the reportdesign color section margins

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 BogdanB 2022-01-26 15:30:59 UTC
Verified no more ON.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 0c3b8792b712e939d2ad524d554f96616b4844be
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded