I’ve noticed I cannot use Fill format mode in the styles sidebar anymore in Windows version. Trying older versions of LibreOffice I found 6.4.x is OK, but since 7.0.x it is broken. 7.2.x is still broken. Steps to reproduce: 1. Open/copy/write several paragraphs of text (preferably unformatted) 2. Open styles side bar, select paragraph styles and set filter to All styles 3. Click on some style (e.g. Heading 1) Actual results: Fill format mode is greyed out Expected results: Fill format mode is selectable I’ve also noticed it works as expected when filter is Hierarchical or when using GTK3 (Linux) version.
Latest version I tested this on: Version: 7.2.2.2 (x64) / LibreOffice Community Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: cs-CZ Calc: threaded
(In reply to Martin Sourada from comment #0) > Actual results: > Fill format mode is greyed out Do you mean the "Clone Formatting" icon in the Standard toolbar? That works for me in single action and in permanent (Ctrl+double-click) mode. The same command in the Sidebar has only single action mode. In case you mean a different command, please attach a screenshot with the grayed out command.
Created attachment 176429 [details] Screenshot of the error
(In reply to Regina Henschel from comment #2) > (In reply to Martin Sourada from comment #0) > > > Actual results: > > Fill format mode is greyed out > > Do you mean the "Clone Formatting" icon in the Standard toolbar? > > That works for me in single action and in permanent (Ctrl+double-click) > mode. The same command in the Sidebar has only single action mode. > > In case you mean a different command, please attach a screenshot with the > grayed out command. I mean the fill format mode in Styles sidebar, screenshot attached (hope you don't mind Czech UI). It's not the same command, it only applies styles (not copying all formatting) and it really speeds it up – when it's working, I consider it killing feature of LO.
@Martin Sourada: Thank you for the screenshot. I have found it now. It is OK in Version: 7.0.0.0.alpha0+ (x64) Build-ID: 6388c578c672690fff662cb04b6a0436cd742f37 CPU-Threads: 8; BS: Windows 10.0 Build 19043; UI-Render: Skia/Vulkan; VCL: win; Gebietsschema: de-DE (en_US); UI-Sprache: de-DE Calc: CL It is broken in Version: 7.0.0.0.beta1+ (x64) Build ID: f92220b73d971e9d760c545efd60179ad1b6902a CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL It is still broken in Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 87e5caca7d3133a32d92503bfa8e5a1409545187 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: threaded It might be due to https://gerrit.libreoffice.org/c/core/+/92942. The "Fill Format Mode" is SFX2_HID_TEMPLDLG_WATERCAN.
Set platform to Windows. It works OK on linux. @Xisco Faulí Is there anyone who can bibisect this on Windows? Do we have bibisect repo for Windows for 7.0 version? Or, if someone has a build environment on Windows, he/she can try to bisect commit fe9a13dc0e6d1384416c2a2343223b33925fc925 to see if that is the bad commit.
@Kevin Suo I have found this: https://bibisect.libreoffice.org/win64-7.0 I'll try to bibisect it, but I have no experience with bibisecting on Windows and the 13 GB download will take a while... And sorry about not filling the platform, I somehow overlooked the field.
Successfully bisected: 1c6663f78a957ca7d233a90655020c06bca8c0ea is the first bad commit commit 1c6663f78a957ca7d233a90655020c06bca8c0ea Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Wed Apr 29 01:10:01 2020 -0700 source fe9a13dc0e6d1384416c2a2343223b33925fc925 $ git bisect log # bad: [dda0d4eaf057b9809ec26c85232c473a08fb0347] source 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08 # good: [832184dd45effc3d2a68e9010c4b8f1d0a70623a] source 9bc848cf0d301aa57eabcffa101a1cf87bad6470 git bisect start 'master' 'oldest' # good: [b10bdc603f9cee0ee563e49fdd92ede3bd724750] source 2940d1905b921d9909b08b1e32014d3c44474ef0 git bisect good b10bdc603f9cee0ee563e49fdd92ede3bd724750 # bad: [877d7c80b082501dde70495c9d7f489ac5c9c7e7] source 12903057343f5d909e400fe778280a1c320923a6 git bisect bad 877d7c80b082501dde70495c9d7f489ac5c9c7e7 # good: [5bd6c2576f3f1812c0f8ebd0b53862149a3b53c1] source 5d105f759ad593591c46aebf3efec9e9a050c441 git bisect good 5bd6c2576f3f1812c0f8ebd0b53862149a3b53c1 # good: [bbcfeb7faa30b15e144befa2f780d2df97f072ca] source 218ad66010fdba3c28564e2038876b6822752243 git bisect good bbcfeb7faa30b15e144befa2f780d2df97f072ca # bad: [1c5b7d031b396f23dfaaf2ed22cceda3583448d8] source 16ab4c5cc82829927c2e876af7e511c0f1fb6284 git bisect bad 1c5b7d031b396f23dfaaf2ed22cceda3583448d8 # bad: [7c99094dba8e038278b8c078773babf3159e2d9c] source 2c366aae9263dc4115b054fe74b90cabea61fa0b git bisect bad 7c99094dba8e038278b8c078773babf3159e2d9c # good: [7fc8c7de16e4b0efcf3cc7ce1928433bad443877] source d829d522d4fc9cab4de4affb6fc0fa37d887e39e git bisect good 7fc8c7de16e4b0efcf3cc7ce1928433bad443877 # bad: [7e2b6c61245a56e60bf09e5cda9d787b8f4a0028] source 1f4a2b698cb5bb987cad5bc2a5503e23dd8a7b9c git bisect bad 7e2b6c61245a56e60bf09e5cda9d787b8f4a0028 # good: [492b49be9bf317e9d5a4e6bb53e494c7d1f749f9] source 14fef320301f71f68547af1c0527677cc0ef6f88 git bisect good 492b49be9bf317e9d5a4e6bb53e494c7d1f749f9 # bad: [1c6663f78a957ca7d233a90655020c06bca8c0ea] source fe9a13dc0e6d1384416c2a2343223b33925fc925 git bisect bad 1c6663f78a957ca7d233a90655020c06bca8c0ea # good: [cd344b74636384feab9a835e884a09a1d487852a] source 58b84caca87c893ac04f0b1399aeadc839a2f075 git bisect good cd344b74636384feab9a835e884a09a1d487852a # good: [6818596157e323438209ecdf29f232a4b8ab9cf4] source f9598b27815dbf9fa4010eda24e4f3f7cc90e3f2 git bisect good 6818596157e323438209ecdf29f232a4b8ab9cf4 # good: [23d1354e4a425b64f55e2a1b5d4f369398305daf] source cf36fe5eb41910c26d58fb25e54ccf2e0ee01365 git bisect good 23d1354e4a425b64f55e2a1b5d4f369398305daf
Thanks for the successful bibisecting. So, the rang is: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=cf36fe5eb41910c26d58fb25e54ccf2e0ee01365..fe9a13dc0e6d1384416c2a2343223b33925fc925 This should be treated as "bisected" as there is only one commit in the range. author Caolán McNamara <caolanm@redhat.com> 2020-04-26 15:43:25 +0100 committer Caolán McNamara <caolanm@redhat.com> 2020-04-29 09:46:08 +0200 commit fe9a13dc0e6d1384416c2a2343223b33925fc925 (patch) tree a43a8ea0cc46407b8932dced64cf34d595f3b3e9 parent cf36fe5eb41910c26d58fb25e54ccf2e0ee01365 (diff) weld SfxTemplatePanelControl Adding Caolán to cc: would you please take look?
looks like the "all styles" is a multiselection case and there for vcl we get an unselect of the old style then a select of the new style, while for gtk we get just the changeselect to the new one. Under gtk the same sort of problem can be seen by ctrl+click to unselect all and click to select something and the state becomes inconsistent there too
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/94960a5594f932a2ba767db21bdf803180a8c761 tdf#145814 fill format mode is mostly disabled It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
done in trunk, backport to 7-2 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/e980aad43ff4f5a3aa07b66ccae200bfb95eabf6 tdf#145814 fill format mode is mostly disabled It will be available in 7.3.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I've just tried latest master and 7.2 dev builds and it appears fixed on master, although not yet in 7.2. Thanks a lot anyway, that was quick! Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ae36ee4f3aa544e53e2edad93d6d79160b27bc9d CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: cs-CZ Calc: CL Version: 7.2.4.0.0+ (x64) / LibreOffice Community Build ID: 26227a0bf6adc64e1a94fd655782054ac92d0993 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: cs-CZ Calc: threaded
(In reply to Martin Sourada from comment #14) It is not merged in 7.2 yet. After it is merged, there will be a message similar as in comment 13. I mark as VERIFIED FIX per your comment.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/e288bd6b0f8eb437ce6830460cf203bf6694272d tdf#145814 fill format mode is mostly disabled It will be available in 7.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fix confirmed in lastest 7.2.x as well. Tested in: Version: 7.2.4.0.0+ (x64) / LibreOffice Community Build ID: 3529262802b77d7c5993d8184e69434b59a6bab2 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: cs-CZ Calc: threaded Thanks again.
7.2.4 was a hotfix release, updating target in status-whiteboard