Comment from Tuomas: "basic library" should be changed to "Basic library" or, bettet yet, "BASIC library", if we're talking about the programming language here. String location https://git.libreoffice.org/core/+/master/uui/inc/ids.hrc#40
Searching about this string, I found: https://opengrok.libreoffice.org/xref/core/uui/source/iahndl.cxx?r=f9ab3136#408 390 script::ModuleSizeExceededRequest aModSizeException; 391 if (aAnyRequest >>= aModSizeException ) 392 { ... 407 handleErrorHandlerRequest( task::InteractionClassification_WARNING, 408 ERRCODE_UUI_IO_MODULESIZEEXCEEDED, 409 aArguments, 410 rRequest->getContinuations(), 411 bObtainErrorStringOnly, 412 bHasErrorString, 413 rErrorString); 414 return true; About ModuleSizeExceededRequest, there's: https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/script/ModuleSizeExceededRequest.idl?r=2b383d19#30 27 /** Is used for interaction handle in case password protected modules exceed the size that can be stored in OpenOffice 2.x, 1.x formats 28 29 */ 30 exception ModuleSizeExceededRequest : ::com::sun::star::uno::Exception ModuleSizeExceededRequest is also used in basctl/source/basicide/moduldl2.cxx and basic/source/uno/modsizeexceeded.cxx Mike: do we mean BASIC module, what about potential Python macro for example? Unless it should be understood another way?
Sophie: shouldn't be the title renamed into "Typo in ERRCODE_UUI_IO_MODULESIZEEXCEEDED" instead? Indeed, ERRCODE_UUI_IO_TARGETALREADYEXISTS corresponds to "Target already exists." which is ok and doesn't contain "basic". From uui/inc/ids.hrc: 38 { NC_("RID_UUI_ERRHDL", "Target already exists."), 39 ERRCODE_UUI_IO_TARGETALREADYEXISTS }, 40 { NC_("RID_UUI_ERRHDL", "You are about to save/export a password protected basic library containing module(s) \n$(ARG1)\nwhich are too large to store in binary format. If you wish users that don't have access to the library password to be able to run macros in those module(s) you must split those modules into a number of smaller modules. Do you wish to continue to save/export this library?"), 41 ERRCODE_UUI_IO_MODULESIZEEXCEEDED },
(In reply to Julien Nabet from comment #2) > Sophie: shouldn't be the title renamed into "Typo in > ERRCODE_UUI_IO_MODULESIZEEXCEEDED" instead? > Yes, you are right, I corrected it, it seems I took the wrong line. Thanks for pointing it and taking care of the issue :)
I had forgotten about this one. Let's put this one to NEW first since we confirmed there's a pb here. Mike: can ERRCODE_UUI_IO_MODULESIZEEXCEEDED be used also for other languages than BASIC (eg: Python)?
(In reply to Julien Nabet from comment #4) > Mike: can ERRCODE_UUI_IO_MODULESIZEEXCEEDED be used also for other languages > than BASIC (eg: Python)? No. This is very specific to our legacy Basic code compiled format.
Thank you for the feedback! I submitted the patch here: https://gerrit.libreoffice.org/c/core/+/130618
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/54e7ac4a8aa5bda78f1c41093fc0d10a56313305 tdf#145829: typo ERRCODE_UUI_IO_MODULESIZEEXCEEDED ("basic" instead of "BASIC") It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Since string freeze is done for 7.3 branch (see https://wiki.documentfoundation.org/ReleasePlan/7.3), let's put this one to FIXED.