Bug 145831 - Typo in Portable Network Graphics string
Summary: Typo in Portable Network Graphics string
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Andrea Gelmini
URL:
Whiteboard: target:7.3.0 target:7.4.0 target:7.3....
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-22 15:52 UTC by sophie
Modified: 2021-11-29 10:32 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sophie 2021-11-22 15:52:49 UTC
Comment from Tuomas: Should be "Portable Network Graphics". "s" is missing.

string location: https://git.libreoffice.org/core/+/master/filter/source/config/fragments/filters/PNG___Portable_Network_Graphic.xcu#24
Comment 1 Julien Nabet 2021-11-22 20:39:52 UTC
Andrea: another for you? :-) (of course, if you don't have time, I can submit a patch quickly).
Just for info, according to https://wiki.documentfoundation.org/ReleasePlan/7.3, hard English string freeze is in mid December.
Comment 2 Andrea Gelmini 2021-11-22 22:31:29 UTC
Yeap, Julien!

I prepare the patch, but before submit I try make check.

Thanks,
Gelma
Comment 3 Commit Notification 2021-11-23 04:50:56 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/f2cbbd18d34a7fb8ece9c774cdcb5a2e38fac957

tdf#145831: fix typo in PNG
Comment 4 Julien Nabet 2021-11-23 08:04:45 UTC
Sophie: following Stephan's feedback on my question in https://gerrit.libreoffice.org/c/core/+/125680, we need some extra info from devs.
See comments in gerrit patch and https://lists.freedesktop.org/archives/libreoffice/2021-November/088080.html.
Comment 5 sophie 2021-11-23 10:07:57 UTC
Thank you both Julien and Andrea for your quick fix! let's wait for developers feedback :)
Comment 6 Andrea Gelmini 2021-11-23 12:39:35 UTC
Just for the record.
On Ubuntu 18.04 it passed "make check"
Comment 7 Commit Notification 2021-11-26 19:25:08 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/93663a64e1a436eddcbaefd4bb0a8f83a925cdb4

tdf#145831: fix typo in PNG

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-11-29 10:32:55 UTC
Andrea Gelmini committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/4300facf4bc6fe0d9765db56720ced99c564caa2

tdf#145831: fix typo in PNG

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.