Bug 145964 - Drag & drop of image with unicode characters in filename does not insert image and shows "Insert Section" dialog
Summary: Drag & drop of image with unicode characters in filename does not insert imag...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All Windows (All)
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2
Keywords:
Depends on:
Blocks: Drag-and-Drop
  Show dependency treegraph
 
Reported: 2021-11-30 12:12 UTC by Thomas K
Modified: 2022-04-07 10:27 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
ZIP file with éĄ.png and works.png mentioned in description (1.01 KB, application/x-zip-compressed)
2021-11-30 12:12 UTC, Thomas K
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas K 2021-11-30 12:12:10 UTC
Created attachment 176592 [details]
ZIP file with éĄ.png and works.png mentioned in description

Note: I noticed this behavior in LibreOffice 7.1.7.2 (x64), but this version is not available in the "Version" dropbox. I selected 7.1.6.2 as the closest version instead.

Steps to reproduce:
1. Open LibreOffice Writer 7.1.7.2
2. Create a new Writer document
2. Drag & drop the attached éĄ.png into the document

Observed behavior:
The "Insert Section" dialog appears. The éĄ.png is not inserted into the document after closing the dialog.

Expected behavior:
The dropped image is inserted into the document without showing a dialog. There should be no difference between dropping the also attached works.png and éĄ.png.
Comment 1 Thomas K 2021-11-30 12:46:05 UTC
Detailed version info:
Version: 7.1.7.2 (x64) / LibreOffice Community
Build ID: c6a4e3954236145e2acb0b65f68614365aeee33f
CPU threads: 16; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: CL
Comment 2 Mike Kaganski 2021-11-30 21:23:28 UTC
https://gerrit.libreoffice.org/c/core/+/126131
Comment 3 LeroyG 2021-11-30 23:03:05 UTC
No reproducible with:
Version: 7.1.7.2 / LibreOffice Community
Build ID: c6a4e3954236145e2acb0b65f68614365aeee33f
CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: kf5
Locale: es-MX (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 4 LeroyG 2021-11-30 23:04:29 UTC
Tested with file name: "1😀ab1.png"
Comment 5 Commit Notification 2021-12-01 05:52:19 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5fb9f4ffa9284c7248e2e82210506babaad4044d

tdf#145964: Windows format name is FileNameW for Unicode strings

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-12-01 14:00:51 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0d2c2ab55a20bfebd87f2296bb8b2d79508de082

tdf#145964 related: also drop special-casing in TransferableHelper::SetString

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-12-03 08:59:08 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/d948282b6ec2a1a217882f8c4fc794d2b85f60e0

tdf#145964: Windows format name is FileNameW for Unicode strings

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-12-03 08:59:19 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/4bb07962ef6c4fbd061dcdb4c637fd31f8c77a73

tdf#145964 related: also drop special-casing in TransferableHelper::SetString

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Thomas K 2022-01-05 15:39:27 UTC
Thank you for the fix, it works as expected in the 7.3 daily build from today (2022-01-05_10.15.17).