Bug 146080 - Wiggling letter when adding dot (4.2)
Summary: Wiggling letter when adding dot (4.2)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Kerning
  Show dependency treegraph
 
Reported: 2021-12-06 18:05 UTC by Telesto
Modified: 2022-01-17 14:49 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (4.71 KB, text/plain)
2021-12-06 18:07 UTC, Telesto
Details
Example File (10.43 KB, application/vnd.oasis.opendocument.text)
2021-12-06 18:07 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-12-06 18:05:04 UTC
Description:
Wiggling letter when adding .

Steps to Reproduce:
1. Open the attached file
2. Press . at the end of second line in 4.2 oldest.. And you will see a wiggle

This bug isn't only for documentation purposes. In attempt to get more structured analysis of the current kerning issues. This isn't an issue today.

Actual Results:
Wiggle

Expected Results:
This working fine after the identified commit.. 


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Telesto 2021-12-06 18:07:22 UTC
Created attachment 176738 [details]
Bibisect log

The wiggled fixed with:
Bisected to
author	Khaled Hosny <khaledhosny@eglug.org>	2013-05-23 09:34:27 +0200
committer	Khaled Hosny <khaledhosny@eglug.org>	2013-05-23 09:50:46 +0200
commit 736adbb4687eaa6b6a7a350a6452df2eceaad960 (patch)
tree 349302bc147dd1317261093fc57f887a284d8e29
parent 62b74b6c21b0b30bbb5a2053dabff375273b0c8e (diff)
Fix left to right full justification
I was overloading ApplyDXArray() with a HarfBuzz specific implementation
because the GenericSalLayout one was screwing right to left kerning, but
it seems to have broken left to right full justifications. Since
mnXOffset was introduced a bit earlier to fix a similar issue, it can
now be used here as well to minimize the possible side effects.

Seems to work fine for both left to right and right to left text now,
but at least one of my Arabic tests is regressing, so might need some
tweaking.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=736adbb4687eaa6b6a7a350a6452df2eceaad96
Comment 2 Telesto 2021-12-06 18:07:47 UTC
Created attachment 176739 [details]
Example File
Comment 3 LeroyG 2021-12-07 00:29:58 UTC
Not sure if this comment helps.

Steps to reproduce:
1. Open the attached file
2.a. Delete the last letter in second line (an "s").
2.b. Or type "Hello.World" (or "He.O") in the third line and wait a few seconds (or press Arrow Up).

Actual Results:
Blue wiggle around the ".".

Version: 7.1.7.2 / LibreOffice Community
Build ID: c6a4e3954236145e2acb0b65f68614365aeee33f
CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: kf5
Locale: es-MX (es_AR.UTF-8); UI: en-US
Calc: threaded
Comment 4 Rainer Bielefeld Retired 2021-12-07 05:52:38 UTC
NOT reproducible with  Installation of Version 7.2.3.2 (x64) / LibreOffice 
Build  d166454616c1632304285822f9c83ce2e660fd92; CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded;  My normal User Profile.

I did not find any zoom reproducing the wiggling.
Comment 5 Telesto 2021-12-07 08:03:38 UTC
(In reply to Rainer Bielefeld Retired from comment #4)
> NOT reproducible with  Installation of Version 7.2.3.2 (x64) / LibreOffice 
> Build  d166454616c1632304285822f9c83ce2e660fd92; CPU threads: 12; OS:
> Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE
> (de_DE); UI: de-DE; Calc: threaded;  My normal User Profile.
> 
> I did not find any zoom reproducing the wiggling.

And actually this more 'backwards' bibisect.. This could be reproduced in LibrOffice 4.2 oldest but not in latest of bibisect 4.2 repro or any later version. 

It's more build-up to bug 146078
Comment 6 Telesto 2022-01-17 14:49:31 UTC
Looks fine
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 52443996eff721e612ac4afc1eb1a53bb8a3e06f
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL