Bug 146230 - OSL warns about no remaining height to distribute
Summary: OSL warns about no remaining height to distribute
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: console-noise
  Show dependency tree / graph
 
Reported: 2021-12-14 19:37 UTC by Eyal Rozenberg
Modified: 2022-11-29 08:27 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2021-12-14 19:37:18 UTC 
When I start LO writer, I get the following console message:

warn:legacy.osl:4695:4695:sfx2/source/sidebar/DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0
warn:legacy.osl:4695:4695:sfx2/source/sidebar/DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0

(yes, I get it twice)

I don't know what height it's distributing, but - either it shouldn't distribute it or it should "have remaining height to distribute".

Build info:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Comment 1 Buovjaga 2022-11-28 12:45:34 UTC 
I'm not seeing it. Do you still see it?

Arch Linux 64-bit
Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 19e3bab1a8def52d9a60f67bd87697e828e37773
CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 28 November 2022

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED WORKSFORME, if the problem went away.
Comment 2 Eyal Rozenberg 2022-11-28 20:38:43 UTC 
(In reply to Buovjaga from comment #1)
> I'm not seeing it. Do you still see it?

Nope. I see other things though... will open new bugs for them :-P
Comment 3 Stephan Bergmann 2022-11-29 08:27:12 UTC 
(In reply to Eyal Rozenberg from comment #2)
> Nope. I see other things though... will open new bugs for them :-P

In general, that (debug, or --enable-sal-log) builds emit such SAL_WARN output is by design, and does not necessarily indicate something that needs fixing or cleaning up:  SAL_WARN is meant to "log warnings about unusual events (that the code nevertheless needs to handle in some way, like malformed input or I/O failures)" (<https://wiki.documentfoundation.org/Development/GeneralProgrammingGuidelines#Assertions_and_Logging>).

(That said, there may be cases where SAL_WARN is used improperly.  Especially if the same SAL_WARN gets triggered an excessive number of times in succession.)

The specific case of such "legacy.osl" warnings (coming from deprecated OSL_ASSERT et al) is covered by bug 43157 "Clean up OSL_ASSERT, DBG_ASSERT, etc."