Description: You can enter new text on the deleted line, but this does not cancel the deletion. In fact, it is even written to the file when saving Steps to Reproduce: 1. Open attached file 2. Turn track changes on 3. Delete a row 4. Write some text in it Actual Results: Writer doesn’t update row deletion Expected Results: Writer should update deletion of the row Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 5242061cca5332ec15cce8c76f070d16e857445d CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL
Created attachment 176951 [details] Screenshot of the problem
Created attachment 176952 [details] Example file from Writer
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8c028b7e41e3d350d0e67005b16faf0159cc5c12 tdf#146244 sw: update HasTextChangesOnly in modified rows It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/02b8bcf06c431ea4694d9fe13d6aa59100c79c05 tdf#146244 sw: update HasTextChangesOnly in modified rows It will be available in 7.3.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
tdf#146244 sw: update HasTextChangesOnly in modified rows It's not forbidden to write in rows deleted or inserted with change tracking, also Accept/Reject only part of the text changes here. Improve to handle these in SwTableLine::UpdateTextChangesOnly() by keeping property HasTextChangesOnly = false (tracked row change) only if 1) there is an insert redline, which is the oldest redline in the row (tracked row insertion) or 2) there is a delete redline, which is the newest redline in the row, and no text outside of redlines, and no insert redline in the row, i.e. whole text content is deleted (tracked row deletion). Also update HasTextChangesOnly table row property at accepting SwRangeRedlines in changed table rows. And follow-up bug fix commits of this: commit bc206f7fd3b4a9e843c81f39dcd2faeeff9c785a "cid#1495785 silence Unchecked return value" and commit 213173edc5e47bb6da11f9a301f4dca71854a48c "sw: fix crash with commit 8c028b7e41e3d350d0e67005b16faf0159cc5c12".
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1edaee2f03bce0efa409c592919458658d0aa751 tdf#146244 sw: fix Undo of accepting table row insertion It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 8f0ce842dffe229d31bd9841ac6e999da1ae976d CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL