Bug 146299 - MsgBox Function doc talks about MB_ABORTRETRYCANCEL instead of MB_ABORTRETRYIGNORE
Summary: MsgBox Function doc talks about MB_ABORTRETRYCANCEL instead of MB_ABORTRETRYI...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-18 13:11 UTC by Julien Nabet
Modified: 2021-12-18 21:44 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
patch (2.19 KB, patch)
2021-12-18 13:33 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nabet 2021-12-18 13:11:59 UTC
On the page https://help.libreoffice.org/latest/en-US/text/sbasic/shared/03010102.html, we can read:
"MB_ABORTRETRYCANCEL  2  Display Abort, Retry, and Ignore buttons."

then later in the example:
sVar = MsgBox("Las Vegas", MB_DEFBUTTON2 + MB_ICONSTOP + MB_ABORTRETRYCANCEL, "Dialog title")

MB_ABORTRETRYCANCEL is a typo, it should be MB_ABORTRETRYIGNORE, see https://opengrok.libreoffice.org/search?project=core&full=MB_ABORTRETRYIGNORE&defs=&refs=&path=&hist=&type=&xrd=&nn=1&si=full&si=full
Comment 1 Julien Nabet 2021-12-18 13:33:14 UTC
Created attachment 177002 [details]
patch

I don't remember how I had succeeded to push a commit on help submodule and https://wiki.documentfoundation.org/Development/Submodules didn't help me.
Comment 2 Julien Nabet 2021-12-18 13:33:51 UTC
Mike: any idea how to push on help part?
Comment 3 Mike Kaganski 2021-12-18 13:41:42 UTC
(In reply to Julien Nabet from comment #2)

I usually use gerrit web interface, and choose help project from BROWSE - Repositories, then in Commands, choose CREATE CHANGE.

https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-directly.html
Comment 4 Julien Nabet 2021-12-18 14:05:18 UTC
(In reply to Mike Kaganski from comment #3)
> (In reply to Julien Nabet from comment #2)
> 
> I usually use gerrit web interface, and choose help project from BROWSE -
> Repositories, then in Commands, choose CREATE CHANGE.
> 
> https://libreoffice-dev.blogspot.com/2020/05/create-patch-for-libreoffice-
> directly.html

Thank you didn't know this!
Here's the patch:
https://gerrit.libreoffice.org/c/help/+/127048
Comment 5 Commit Notification 2021-12-18 15:28:02 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/84b6347bd05d0a7e5a7ea5075702f5f2892b5c1f

tdf#146299: MsgBox can have the parameter MB_ABORTRETRYIGNORE
Comment 6 Julien Nabet 2021-12-18 16:11:25 UTC
Don't know if we can/should backport in 7.3 branch but let's put this one to FIXED then.
Comment 7 Commit Notification 2021-12-18 21:44:29 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/help/commit/94884d21074aced3d03e93f607d5be5f813414b4

tdf#146299: MsgBox can have the parameter MB_ABORTRETRYIGNORE