Description: My LO build is broken since commit be446d81e07b5499152efeca6ca23034e51ea5ff "only use X509Data" (https://cgit.freedesktop.org/libreoffice/core/commit/?id=be446d81e07b5499152efeca6ca23034e51ea5ff). When I checkout the previous commit, the build is successful. Steps to Reproduce: 1. Checkout be446d81e07b5499152efeca6ca23034e51ea5ff 2. Call make Actual Results: [CXX] xmlsecurity/inc/pch/precompiled_xsec_xmlsec.cxx [CXX] xmlsecurity/source/xmlsec/biginteger.cxx [CXX] xmlsecurity/source/xmlsec/certificateextension_certextn.cxx [CXX] xmlsecurity/source/xmlsec/errorcallback.cxx [CXX] xmlsecurity/source/xmlsec/saxhelper.cxx [CXX] xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx [CXX] xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx [CXX] xmlsecurity/source/xmlsec/xmlsec_init.cxx [CXX] xmlsecurity/source/xmlsec/xmlstreamio.cxx [CXX] xmlsecurity/source/gpg/CertificateImpl.cxx [CXX] xmlsecurity/source/gpg/CipherContext.cxx [CXX] xmlsecurity/source/gpg/DigestContext.cxx [CXX] xmlsecurity/source/gpg/SecurityEnvironment.cxx [CXX] xmlsecurity/source/gpg/SEInitializer.cxx [CXX] xmlsecurity/source/gpg/XMLEncryption.cxx [CXX] xmlsecurity/source/gpg/XMLSecurityContext.cxx [CXX] xmlsecurity/source/gpg/xmlsignature_gpgimpl.cxx [CXX] xmlsecurity/source/xmlsec/nss/ciphercontext.cxx [CXX] xmlsecurity/source/xmlsec/nss/digestcontext.cxx [CXX] xmlsecurity/source/xmlsec/nss/nssinitializer.cxx [CXX] xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx [CXX] xmlsecurity/source/xmlsec/nss/secerror.cxx [CXX] xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx [CXX] xmlsecurity/source/xmlsec/nss/seinitializer_nssimpl.cxx [CXX] xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx [CXX] xmlsecurity/source/xmlsec/nss/xmlsecuritycontext_nssimpl.cxx /devel/libreoffice/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx:524:36: error: use of undeclared identifier '__CERT_NewTempCertificate'; did you mean 'CERT_NewTempCertificate'? CERTCertificate* certTmp = CERT_NewTempCertificate(certDb, &item, ^~~~~~~~~~~~~~~~~~~~~~~ CERT_NewTempCertificate /devel/libreoffice/xmlsecurity/source/xmlsec/nss/nssrenam.h:37:33: note: expanded from macro 'CERT_NewTempCertificate' #define CERT_NewTempCertificate __CERT_NewTempCertificate ^ /devel/libreoffice/workdir/UnpackedTarball/nss/dist/public/nss/cert.h:286:25: note: 'CERT_NewTempCertificate' declared here extern CERTCertificate *CERT_NewTempCertificate(CERTCertDBHandle *handle, ^ 1 error generated. make[1]: *** [/devel/libreoffice/solenv/gbuild/LinkTarget.mk:332: /devel/libreoffice/workdir/CxxObject/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.o] Error 1 make[1]: *** Waiting for unfinished jobs.... /devel/libreoffice/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx:311:12: error: use of undeclared identifier '__CERT_DecodeDERCertificate'; did you mean 'CERT_DecodeDERCertificate'? cert = CERT_DecodeDERCertificate( &certItem, PR_TRUE, nullptr ) ; ^~~~~~~~~~~~~~~~~~~~~~~~~ CERT_DecodeDERCertificate /devel/libreoffice/xmlsecurity/source/xmlsec/nss/nssrenam.h:39:35: note: expanded from macro 'CERT_DecodeDERCertificate' #define CERT_DecodeDERCertificate __CERT_DecodeDERCertificate ^ /devel/libreoffice/workdir/UnpackedTarball/nss/dist/public/nss/cert.h:403:25: note: 'CERT_DecodeDERCertificate' declared here extern CERTCertificate *CERT_DecodeDERCertificate(SECItem *derSignedCert, ^ 1 error generated. make[1]: *** [/devel/libreoffice/solenv/gbuild/LinkTarget.mk:329: /devel/libreoffice/workdir/CxxObject/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.o] Error 1 make: *** [Makefile:290: build] Error 2 Expected Results: LO build successful Reproducible: Always User Profile Reset: No Additional Info: My configuration: ./autogen.sh CC=clang CXX=clang++ --enable-pch=full --without-doxygen --without-system-libxml --without-krb5 --disable-randr --disable-gtk3 --disable-gstreamer-1-0 --without-gssapi --with-theme=breeze --enable-dbgutil My OS: Linux 5.3.18-59.37-preempt #1 SMP PREEMPT Mon Nov 22 12:29:04 UTC 2021 (d10168e) x86_64 x86_64 x86_64 GNU/Linux
Author and committer of commit added. I assume this build problem is environment specific.
Compiler: clang version 11.0.1 Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/bin Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-suse-linux/7 Found candidate GCC installation: /usr/lib64/gcc/x86_64-suse-linux/7 Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-suse-linux/7 Candidate multilib: .;@m64 Selected multilib: .;@m64
seeing as --enable-pch=full is uncommon, maybe try toggling that off and see if it makes a difference
Building with only --enable-pch is successful. My commands: make clean ./autogen.sh CC=clang CXX=clang++ --enable-pch --without-doxygen --without-system-libxml --without-krb5 --disable-randr --disable-gtk3 --disable-gstreamer-1-0 --without-gssapi --with-theme=breeze --enable-dbgutil make
At the top of each file in xmlsecurity/inc/pch/precompiled_x*hxx there is a line to update the pch e.g. ./bin/update_pch ... If you run each of the update_pch suggestions and retry with --enable-pch=full does it make a difference. If it does you can commit and submit the change as a fix for this.
I've created a patch: https://gerrit.libreoffice.org/c/core/+/127744
scito committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/67fb363eed88b15eec7821fe604eb23d142d84cc tdf#146392 fix --enable-pch=full build It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
scito committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/a787ae33c9c3c20043c89893859cafdc45061a3a tdf#146392 fix --enable-pch=full build It will be available in 7.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
scito committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/511056fa1609d523206ce995c42555451b59e80b tdf#146392 fix --enable-pch=full build It will be available in 7.2.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.