Bug 146449 - Image in frame not restored (visible) after undo (only after moving the frame)
Summary: Image in frame not restored (visible) after undo (only after moving the frame)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 beta1+
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.4.0
Keywords: bibisected, bisected, regression
: 144891 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-12-28 11:05 UTC by Telesto
Modified: 2022-04-29 07:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (679.29 KB, application/vnd.oasis.opendocument.text)
2021-12-28 11:07 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-12-28 11:05:28 UTC 
Description:
Image in frame not restored (visible) after undo (only after moving the frame)

Steps to Reproduce:
1. Open the attached file
2. Select figure 1 frame
3. CTRL+X
4. CTRL+Z

Actual Results:
Empty frame

Expected Results:
Visible content


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 9c95415de877af1430ab5b7123e11dedd0ea622c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-12-28 11:07:05 UTC 
Created attachment 177170 [details]
Example file
Comment 2 Telesto 2021-12-28 11:09:13 UTC 
Found in 7.3

not in
Version: 7.2.1.0.0+ (x64) / LibreOffice Community
Build ID: 8fdbb8aed1b48734a717d5f98ada566de7204605
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 3 m_a_riosv 2021-12-30 17:20:00 UTC 
Reproducible.
Version: 7.3.0.1 (x64) / LibreOffice Community
Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 6dbe55d34ad65627ef37f10dfdb548a717bb8c78
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Comment 4 Deep17 2022-01-03 17:26:11 UTC 
I can't reproduce the issue in 

Version: 7.2.4.1 (x64) / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

and

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dd1b0471b70f9b5c5db6b681c1fceacfe17c9349
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 5 Telesto 2022-01-03 17:54:27 UTC 
Still present
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 1bb0e177124d5d6661b72df6c7d848fb23639652
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 6 Deep17 2022-01-04 04:11:35 UTC 
(In reply to Deep17 from comment #4)
> I can't reproduce the issue in 
> 
> Version: 7.2.4.1 (x64) / LibreOffice Community
> Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
> CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL:
> win
> Locale: en-US (en_US); UI: en-US
> Calc: threaded
> 
> and
> 
> Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: dd1b0471b70f9b5c5db6b681c1fceacfe17c9349
> CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (en_US); UI: en-US
> Calc: threaded

I am able to reproduce the issue in 

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dd1b0471b70f9b5c5db6b681c1fceacfe17c9349
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 7 Deep17 2022-01-04 04:39:42 UTC 
Regression introduced by:

https://git.libreoffice.org/core/commit/504d78acb866495fd954fcd6db22ea68f174a5ab

commit 504d78acb866495fd954fcd6db22ea68f174a5ab	[log]
author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	Fri Aug 13 14:11:24 2021 +0200
committer	László Németh <nemeth@numbertext.org>	Wed Sep 01 10:09:37 2021 +0200
tree 454c012ca959cf144c3380a7e7b58561fac3704e
parent 9c9ff9e89fd50223b28f327d3a7e416ab0ae831f [diff]

Bisected with : bibisect-win64-7.3
Adding CC : to Attila Bakos
Comment 8 Attila Bakos (NISZ) 2022-03-02 13:12:53 UTC 
Fix is there:
https://gerrit.libreoffice.org/c/core/+/130875
Comment 9 Attila Bakos (NISZ) 2022-03-07 12:21:03 UTC 
*** Bug 144891 has been marked as a duplicate of this bug. ***
Comment 10 Commit Notification 2022-04-27 14:44:31 UTC 
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a3e540304269772595439de22b54269011721bb2

tdf#146449 sw: fix Z-order after undoing

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 NISZ LibreOffice Team 2022-04-29 07:30:04 UTC 
The problem in this report is checked and works correctly, but when I cut it and undo a drawing object frame the autocaption doesn't work correctly.
The undo frame doesn't get back the previous caption.  

See also: https://bugs.documentfoundation.org/show_bug.cgi?id=148845 

Verified in: 
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 83d0f2eebae41d431d9a5bfd1a918523977752d0
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL