Bug 146536 - Improper display of newly added text in front of formula object
Summary: Improper display of newly added text in front of formula object
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
: 148212 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-01-03 06:36 UTC by d00m3d.olw
Modified: 2022-06-29 03:27 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample odt with formula objects. (19.66 KB, application/vnd.oasis.opendocument.text)
2022-01-03 06:39 UTC, d00m3d.olw
Details
Text display correctly before formula objects. (24.44 KB, image/png)
2022-01-03 06:40 UTC, d00m3d.olw
Details
Text incorrectly displayed before formula objects. (2.53 KB, image/png)
2022-01-03 06:40 UTC, d00m3d.olw
Details

Note You need to log in before you can comment on or make changes to this bug.
Description d00m3d.olw 2022-01-03 06:36:26 UTC
Description:
In LO 7.3.x+, newly added text cannot be displayed properly in front of formula object.  The formula object itself is displayed properly.
In print preview mode, everything looks fine.  When exited preview mode, everything also looks fine but adding new text before formula object cannot be displayed properly again.

Steps to Reproduce:
1. Start Writer
2. Create a new Formula Object, exit formula editor.  Alternatively, open the attached sample odt.
3. In normal text editor, move cursor before formula object
4. Insert NEW text

Actual Results:
NEWLY inserted text before formula object cannot be displayed properly.

Expected Results:
NEWLY inserted text should be displayed properly.


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested LO versions with improper display:

Version: 7.3.0.1.0+ (x64) / LibreOffice Community
Build ID: bd7f01c4ca5222d8d3293cc81802cfd6c0bfdcc3
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dd1b0471b70f9b5c5db6b681c1fceacfe17c9349
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version of LO last known good:

Version: 6.4.8.0.0+ (x64)
Build ID: 188ddcd482150b5fdeb44d97e57831e3e27b3f5b
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: GL; VCL: win; 
Locale: en-HK (en_HK); UI-Language: en-US
Calc: CL

Version: 7.0.7.0.0+ (x64)
Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version: 7.1.8.0.0+ (x64) / LibreOffice Community
Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version: 7.2.6.0.0+ (x64) / LibreOffice Community
Build ID: df77dcbbb2ecd3a272a3ea55877a1b1c9fd8ef03
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

I have no ideas when was this first happened but it does not seems to have same problem with versions prior to 7.3.

I would be highly appreciated if this regression could be fixed before formal release of 7.3.

Thanks a lot!
Comment 1 d00m3d.olw 2022-01-03 06:39:01 UTC
Created attachment 177266 [details]
Sample odt with formula objects.
Comment 2 d00m3d.olw 2022-01-03 06:40:13 UTC
Created attachment 177267 [details]
Text display correctly before formula objects.
Comment 3 d00m3d.olw 2022-01-03 06:40:57 UTC
Created attachment 177268 [details]
Text incorrectly displayed before formula objects.
Comment 4 raal 2022-01-18 21:38:22 UTC
I can confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 3e94991d7fd3a085549c3a5d4c991688042d2cb9
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

Works in Version: 7.1.0.0.alpha1+
Build ID: 738bcf5e9a8c443d60c29c3a8068e8c16c72638a
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 5 raal 2022-01-18 21:48:16 UTC
This seems to have begun at the below commit.
Adding Cc: to Luboš Luňák; Could you possibly take a look at this one?
Thanks
 d307a5b5865923b0ad3f41a31f1cb05ecb20ab66 is the first bad commit
commit d307a5b5865923b0ad3f41a31f1cb05ecb20ab66
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Oct 5 08:07:29 2021 +0200

    source 71429b93ec0687bbbedcbb776b38c981f4017177

https://gerrit.libreoffice.org/c/core/+/123077
  try to merge rectangles already in AddPaintRect()
Comment 6 d00m3d.olw 2022-02-03 02:55:39 UTC
I am glad to know that the official LO-7.3 was released on yesterday.  However, I am quite disappointed that this regression is still not fixed before that.
Comment 7 Luboš Luňák 2022-06-20 10:41:18 UTC
*** Bug 148212 has been marked as a duplicate of this bug. ***
Comment 8 Commit Notification 2022-06-20 12:27:12 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a6b9fbfc15b9e1756ac8ea939b4c588e3f170c1d

fix SwViewShellImp::AddPaintRect() for sub-rects (tdf#146536)

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-06-20 14:15:01 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/2cff5e170925ef3f7904f33495c9b1aa7207b8eb

fix SwViewShellImp::AddPaintRect() for sub-rects (tdf#146536)

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-06-20 15:10:35 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/c0d9d30d8e2900c23b5d0ccac49064d2fb6650f3

fix SwViewShellImp::AddPaintRect() for sub-rects (tdf#146536)

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 d00m3d.olw 2022-06-22 09:29:39 UTC
I just tried with the following versions, both dated and downloaded Jun 22, 2022:

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 086055b0d7e44d1d07b3f23af55503e6a3924d87
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_HK); UI: en-US
Calc: CL

Version: 7.3.5.0.0+ (x64) / LibreOffice Community
Build ID: f894fa135bea1b33c51fd94e2138a7c9b16b2776
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_HK); UI: en-US
Calc: CL

I can confirm both of them works well.  I cannot find a download link for 7.4-beta2 but I trust this bug will no longer exist.

Thank you very much.

Cheers!
Comment 12 d00m3d.olw 2022-06-29 03:27:04 UTC
I just downloaded and tested a new snapshot from the 7.4-branch latest daily build dated Jun 28, 2022.

Version: 7.4.0.0.beta1+ (x64) / LibreOffice Community
Build ID: a083ff62b52437e810a183ab162e0f895fa81cac
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_HK); UI: en-US
Calc: CL

Despite it still labelled as 7.4-beta1, this formula object display bug is gone.

Thanks again for fixing this bug in all branches.

Cheers!