Description: I use almost all apps in dark mode (I use linux) except LO; which is mainly because I think there is no better icon style than Colibre. However Colibre is not available in dark variant (and I 'd prefer to use light mode than other dark variant ...). It 'd be really nice to have a dark variant of Colibre icon style. Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: -
Colibre is a Windows specific icon theme using MS icon guidelines. You'd be asking for a lot of design work for an icon theme that for now (depending on bug 118320) can not even be used on its target os/DE dark theme. But at some point support of Windows os/DE dark mode themes may require Colibre icon theme be recast for use in a dark mode. It just is not needed now (Breeze and Sifr suffice cross-platform, and Sifr is used on Windows when os/DE HighContrast triggers assistive technology mode. @Andreas, what are your thoughts on color rework of the Colibre SVG?
-1 to add more icon themes in general (big +1 for extensions). And -1 for Colibre as Windows has no dark mode yet. Andreas, please reopen if you think Colibre dark is a must-have.
I would like to work on this request. Pros - Dark mode is a norm nowadays. Although at the moment LIbreOffice doesn't fully support this dark mode on the Windows platform, I'm sure it will happen sooner or later. - This Colibre dark icon theme can be used in other operating systems/ environments besides Windows that already support dark mode, for example on the GNOME DE which currently uses elementary which does not support dark mode (There is a discussion (https://github.com/elementary/icons/discussions) /1088) which I wanted to chat with upstream elementaryOS but no response yet) - The presence of Colibre, which has a reference to Office 365, really helps to glue the familiarity of users of the proprietary application. Adding support for dark mode hopefully has more impact on the migration process. - There is a consistent trend of the documentation team always using the Colibre icon theme in their publications, regardless of the operating system the screenshot is based on. Included in this help page also use Colibre. So I think it really deserves the Colibre to receive more affection. :D Cons - Increase the size of the installation file. We can discuss this again whether we need to issue some of the default icon themes as an extension? Karasa Jaga, for example, which is not the default theme for any operating system, can be removed. - Increase the maintenance burden. I'll work around this as I've done so far with the icon themes Breeze (https://github.com/rizmut/libreoffice-style-breeze/blob/master/build.sh) and Sifr (https://github. com/rizmut/libreoffice-style-sifr/blob/master/build.sh) by using a custom script.
Here the patch https://gerrit.libreoffice.org/c/core/+/131411
(In reply to Rizal Muttaqin from comment #3) > I would like to work on this request. That's good news! But I wonder if all the dark variants wouldn't be better suited for the extensions site as they are neither picked as default like KJ. Ultimately I wish we use SVG only and tweak the color scheme depending on the theme brightness (bug 124966).
If you curious about how it looks, here some screenshots: https://github.com/rizmut/libreoffice-style-colibre/pull/39
(In reply to Heiko Tietze from comment #5) > That's good news! But I wonder if all the dark variants wouldn't be better > suited for the extensions site as they are neither picked as default like KJ. > > Ultimately I wish we use SVG only and tweak the color scheme depending on > the theme brightness (bug 124966). Yes, a dynamic approach will be more suitable. While we are waiting, let's use current approach first.
+1 to including this as default. It's a great addition for Windows users that wish to make their own dark theme by selecting the LibreOffice Dark Color Scheme in Options -> Application colors and selecting the dark theme in Options -> Personalization. It would further show some progress being made to supporting dark mode for Windows, even if this is an illusion since there's no interest from development to pick this up. I am against moving the dark variants to the extension website because it also removes the option from users in Linux from quickly using different dark icon sets. If the issue is increasing install size, I agree with Rizal that removing icon sets that are not default in any desktop environment is the way to go. Not removing Dark variants of default icon sets. I would even add a dark icon variant for Elementary and Sukapura as well. If increased install size is still a concern remove the experimental SVG icons.
Thanks Rizal for going ahead and tackling this. Those are looking great! (In reply to Pedro from comment #8) >... > > I am against moving the dark variants to the extension website because it > also removes the option from users in Linux from quickly using different > dark icon sets. > +1 >... > If increased install size is still a concern remove the experimental SVG > icons. SVG icons are not "experimental", rather all SVG icon themes are reparsed for use at high UI scaling and for HiDPI support.
+1 for colibre dark we wait since 2014 for svg support.
My personal opinion is that every default installed font should have a corresponding dark theme. Particularly those that are the OS default, Colibre in this case for Microsoft Windows,yes Windows does not have a working dark mode but that is another story and bug report. Rizal, that is outstanding work, very well done! I hope we see this as a default installed font(certainly on Windows)in LibreOffice 7.4 if not a point release for 7.3.x. Please don't make dark fonts an optional extension. Having them by default is a statement of intent that the dark mode is an integral part of the LibreOffice experience. Colibre is a beautiful icon set and we should be very proud of showing off the quality of the artwork from the community. Congratulations once again!
(In reply to andreas_k from comment #10) > +1 for colibre dark > > we wait since 2014 for svg support. I thought SVG support was still experimental and that's why we still had the .png icons. I must've misunderstood wrong since V Stuart Foote corrected me. Still trying to catch up with everything. Since it seems we are still waiting for things from 2014 it seems I won't have a lot of catching up to do.
(In reply to John Mills from comment #11) These are Icon themes, not fonts. Bundling all dark mode icon themes as extension (bundled or via extension repository) would be a viable packaging decision of the ESC, and distribution builders. Though personally I don't see a need for use of extension here. (In reply to Pedro from comment #12) > (In reply to andreas_k from comment #10) > > +1 for colibre dark > > > > we wait since 2014 for svg support. > > I thought SVG support was still experimental and that's why we still had the > .png icons. I must've misunderstood wrong since V Stuart Foote corrected me. > Still trying to catch up with everything. > > Since it seems we are still waiting for things from 2014 it seems I won't > have a lot of catching up to do. SVG is supported. Selected Icon theme is rendered once--per soffice.bin launch--to PNG at a resolution appropriate for the UI scaling in use. What is not yet provided, and may never be, is dynamic use of SVG icon themes (bypassing the rendering from SVG to PNG raster).
> These are Icon themes, not fonts. Slip of the wrist when typing Stuart, I realise these are icons. But the fact still remains, a dark mode is an expected feature of modern software. The ability to use these icons aids with that ability and I commend Rizal on what he has done as it is great work. And my opinion is that these icons be available by default on Windows installations of LibreOffice. Also the Windows version of LibreOffice on Microsoft Windows lags behind Linux / GTK. This should be rectified particularly in the UI aspect of the application. I find it strange that the largest user base for LibreOffice has arguably the worst user experience of the software. If these type of discrepancies continue then the user base on Windows will fall as competing products offer this functionality. Or are Windows users no longer a first class citizen for LibreOffice? I wonder what would happen if there donations stopped, would there be enough from Linux and Mac OS users for the Documentation to undertake their work?
Their donations even for the pedants.
Is there anyway for the Document Foundation to check as a percentage what the breakdown of donations are by OS? I assume as you donate when you download the software it shouldn't be too difficult to come up with those figures. Perhaps the DF would prefer not to focus on Windows anymore and forego their donations?
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e16da3ea406a07c61eef763e5d30563ff1bbb099 Colibre: tdf#146545 Add dark variant It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e2d25709fd5f31849ed9db3d51811ddb44c8e5cc Colibre: tdf#146545 Fix some color, remove gradient to fully It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/122e9364ab297661ed91854f192c7a880eb08634 Related tdf#146545 - Make Colibre (Dark) available in icon themes It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.