Bug 146554 - Document Statistics tab missing with Explorer integration (x64)
Summary: Document Statistics tab missing with Explorer integration (x64)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-03 22:39 UTC by Aron Budea
Modified: 2022-01-05 12:44 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Screenshot (12.60 KB, image/png)
2022-01-03 22:39 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2022-01-03 22:39:09 UTC
Created attachment 177298 [details]
Screenshot

Explorer integration adds a tab named "Document Statistics" when right-clicking on a document, and selecting Properties (see attached screenshot, it's from LO 5.2.0.4, but it's the same in a recent version).

This tab is there if a 32-bit LO build is installed, but not if a 64-bit one is installed.

Tested with LO 7.3.0.1 (x86 & x64), LO 6.0.0.3 (x86 & x64) / Windows.
Comment 1 Mike Kaganski 2022-01-05 09:34:35 UTC
Confirm.

The problem is MODULE_NAME in shell/inc/config.hxx, which is shlxthdl_x64.dll in 64-bit builds, while the module name is simply shlxthdl.dll.

I suppose that we should use shlxthdl_x64.dll for 64-bit build, not try to "fix" the MODULE_NAME define, because it would enable us to provide both 32- and 64-bit handlers in 64-bit builds, just as we do for 32-bit builds - and that would also enable the handlers to work inside 32-bit applications on Windows. Also that would avoid adding complexity to the code.
Comment 2 Mike Kaganski 2022-01-05 10:25:01 UTC
https://gerrit.libreoffice.org/c/core/+/127993
Comment 3 Commit Notification 2022-01-05 12:12:51 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d75bf2c7703d6a741f04e4a3fc5a6180428f53b2

tdf#146554: use GetModuleHandleExW instead of GetModuleHandleW

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.