Bug 146571 - Crash when close Manage changes dialog
Summary: Crash when close Manage changes dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.5.2 release
Hardware: All Linux (All)
: high major
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.1 target:7.2.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-01-04 20:11 UTC by raal
Modified: 2022-01-25 15:39 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
test file (17.62 KB, application/vnd.oasis.opendocument.text)
2022-01-04 20:11 UTC, raal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2022-01-04 20:11:28 UTC
Description:
The file from bug 146171. Docx file saved as ODT (Tracked changes with no date (0000-00-00)).

Steps to Reproduce:
 - open attached file
 - menu Edit > Track changes > Manage
 - click Filter tab
 - select checkbox Date
 - Click on calendar picklist and open it. Select date not necessary, close the picklist.
 - close the dialog with red cross.

Actual Results:
crash

Expected Results:
no crash


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: c13db6e792cc347ffff4585f23866f195651f21f
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo
Comment 1 raal 2022-01-04 20:11:55 UTC
Created attachment 177314 [details]
test file
Comment 2 Telesto 2022-01-05 12:44:44 UTC
No crash with
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 1bb0e177124d5d6661b72df6c7d848fb23639652
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

But build is 8 days old.. & win
Comment 3 Deep17 2022-01-14 03:16:51 UTC
No crash with

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bb29b12a9e367d181a5d9d962d466df41e093e0c
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 4 Timur 2022-01-14 12:16:01 UTC
No repro 7.1+. Repro 7.2+ and 7.4+. GTK3. Linux Mint 19 based on Ubuntu 18.04.
So it's hidden in 7.2 repo.
Comment 5 Xisco Faulí 2022-01-14 15:56:30 UTC
I can't reproduce it in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d73e45a89a7d4b11442b568a47e65231735d9699
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Raal, what version of GTK3 do you have? OTOH, do you reproduce it with GEN ?
Comment 6 raal 2022-01-14 18:00:18 UTC
Error in command line:
pure virtual method called
terminate called without an active exception
Unspecified Application Error

I can reproduce with GEN. 
OS UBUNTU 21.04, X11, libgtk-3-0:amd64  3.24.25-1ubuntu4.1
Comment 7 Xisco Faulí 2022-01-14 18:45:34 UTC
oh I see the problem, the calendar needs to be displayed in other to reproduce the crash...
Comment 8 Xisco Faulí 2022-01-14 18:46:18 UTC
In fact, it can be reproduced with an empty file
Comment 9 Xisco Faulí 2022-01-14 18:51:41 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac

author	Noel Grandin <noel.grandin@collabora.co.uk>	2021-05-29 08:34:28 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2021-05-29 13:37:25 +0200
commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac (patch)
tree 73b645a8b6c5976c29a83908ac3be49744ddcbb0
parent 30aa33e6a6b9fb230af96f619db27fcaf31ef914 (diff)
IsDisposed->isDisposed in vcl/../window

Bisected with: bibisect-linux64-7.2

Adding Cc: to Noel Grandin
Comment 10 Xisco Faulí 2022-01-14 18:54:16 UTC
Indeed, this is only Linux. I can't reproduce it on Windows
Comment 11 Commit Notification 2022-01-25 09:05:38 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9446b3ccd1240dbd44cbe1f1ccdfca04b61c85af

tdf#146571 Ignore focus changes after closing Manage changes dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Caolán McNamara 2022-01-25 10:41:19 UTC
should be fixed in trunk, backports to 7-3 and 7-2 in gerrit
Comment 13 Xisco Faulí 2022-01-25 10:49:04 UTC
Verified in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 9446b3ccd1240dbd44cbe1f1ccdfca04b61c85af
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!!
Comment 14 Commit Notification 2022-01-25 12:46:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/7c1ca3b3916b3216188cdb32852cb2058cf070f3

tdf#146571 Ignore focus changes after closing Manage changes dialog

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2022-01-25 15:39:34 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/333ad127b915e6d318df4eef4f30f9231b5f8a95

tdf#146571 Ignore focus changes after closing Manage changes dialog

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.