Bug 146592 - radiobutton's selecting jumps between items after Apply button pressing
Summary: radiobutton's selecting jumps between items after Apply button pressing
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.8.1 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.0.2 target:7.2.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Options-Dialog-Calc
  Show dependency treegraph
 
Reported: 2022-01-05 14:47 UTC by Roman Kuznetsov
Modified: 2022-01-09 16:43 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2022-01-05 14:47:23 UTC
Description:
radiobutton's selecting jumps between items after Apply button pressing

Steps to Reproduce:
1. Open Calc
2. Open Tools->Options
3. Select LibreOffice Calc->Calculate
4. Select "No wildcards or regular expressions in formulas" option
5. Press Apply button => selecting in the radio button group jumped to "Enable wildcards in formulas" option

Actual Results:
radiobutton's selecting jumps between items after Apply button pressing

Expected Results:
radiobutton's selecting stays on selected item after Apply button pressing


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 1be170d0629cf761f0ee4173007a3c021966546e
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

and in

Version: 7.1.7.2 (x64) / LibreOffice Community
Build ID: c6a4e3954236145e2acb0b65f68614365aeee33f
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

but not in

Version: 7.0.5.2 (x64)
Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

regression
Comment 1 Roman Kuznetsov 2022-01-05 15:49:12 UTC
I bisected this in win64-7.1 bisect repo and got

sha: 78c6e88e163f50eccc1cebdb2defe9ec4af248ce

https://gerrit.libreoffice.org/c/core/+/105020

https://git.libreoffice.org/core/commit/78c6e88e163f50eccc1cebdb2defe9ec4af248ce

Added to CC: Caolán McNamara

Caolán could you please look at it?
Comment 2 m_a_riosv 2022-01-05 17:10:50 UTC
Happens also with:
Version: 7.2.5.1 (x64) / LibreOffice Community
Build ID: 6d497ff5e83a906a307eb25cce314d40c0b8624f
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Comment 3 Caolán McNamara 2022-01-05 21:00:19 UTC
that page is holding its "old options" differently than the other pages
Comment 4 Commit Notification 2022-01-06 09:00:23 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d99efe24213400932b97e47b131049fcbbfac612

Resolves: tdf#146592 "Reset" to the current document properties

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Mike Kaganski 2022-01-06 10:08:06 UTC
(In reply to Caolán McNamara from comment #3)
> that page is holding its "old options" differently than the other pages

I realize that this is another issue, but just wanted to mention that the same happens on Options->LibreOffice->View, impossible to set Visibility/Menu Icons to Hide (it resets to Show) (It is not visible on gtk3 - so might need Windows to see). So there might be some common pattern there?
Comment 6 Caolán McNamara 2022-01-06 11:32:35 UTC
(In reply to Mike Kaganski from comment #5)
> (In reply to Caolán McNamara from comment #3)
> > that page is holding its "old options" differently than the other pages
> 
> I realize that this is another issue, but just wanted to mention that the
> same happens on Options->LibreOffice->View, impossible to set
> Visibility/Menu Icons to Hide (it resets to Show) (It is not visible on gtk3
> - so might need Windows to see). So there might be some common pattern there?

That seems to be unrelated to the apply/ok unification, that is likely a regression from:

commit 131759a3db51140c21594308ed99c71aa7aba43a
Date:   Sun Jul 25 16:21:39 2021 +0200

    use officecfg for menu options
    
    Change-Id: I94c9cf310ed6975f158548913439445faf6d178f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119483

so a new issue for that is indicated.
Comment 7 Caolán McNamara 2022-01-06 11:34:48 UTC
done in trunk, backport to 7-3 and 7-2 in gerrit
Comment 8 Commit Notification 2022-01-07 10:22:37 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/3399f4d95ec1e685bd48936f1131dd8c860aebf4

Resolves: tdf#146592 "Reset" to the current document properties

It will be available in 7.3.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-01-09 16:43:25 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/ea800e3bf861a6a6bf338e72cc55959d32b5af48

Resolves: tdf#146592 "Reset" to the current document properties

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.