Bug 146609 - Width property does not work in right-sidebar via "Position and Size" panel
Summary: Width property does not work in right-sidebar via "Position and Size" panel
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Adam Fallon
URL: https://youtu.be/xWz-jPyWRzk
Whiteboard: target:24.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Sidebar-Properties-PositionAndSize
  Show dependency treegraph
 
Reported: 2022-01-06 10:48 UTC by dainius.mazuika
Modified: 2023-10-06 13:40 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dainius.mazuika 2022-01-06 10:48:04 UTC
Description:
1. Draw a line, set some properties in right-sidebar via "Position and Size" panel.
2. Change property "Width" there -> nothing changes. Line width should be changed instead.

See youtube screencast: https://youtu.be/xWz-jPyWRzk

Actual Results:
Change property "Width" there -> nothing changes. 

Expected Results:
Line width should be changed instead.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Buovjaga 2022-12-02 13:42:46 UTC
Doing some tests, it seems to be working logically: the width and height refer to the bounding box of the object. When a line object is rotated 90 degrees like in your video, changing the width has no visible effect. The line length changes, when you touch the height property in this case.

Question for the design team: is there anything we can do about the labels of the controls? One unfortunate thing of course is that there is another "Width", for the thickness. Difficult topic.
Comment 2 Heiko Tietze 2022-12-02 16:22:11 UTC
What is the width of a vertical / height of a horizontal line? I see no problem.
Comment 3 Buovjaga 2022-12-02 16:38:36 UTC
(In reply to Heiko Tietze from comment #2)
> What is the width of a vertical / height of a horizontal line? I see no
> problem.

In case of a line, you see the effects of adjusting width / height as the length of the line. It is adjusting the bounding box of the object in truth. The bounding box aspect you will see best when you rotate the line diagonally.
Comment 4 Heiko Tietze 2022-12-02 17:13:47 UTC
It was a rhetorical question as follow-up to your bounding box explanation.
Comment 5 V Stuart Foote 2022-12-02 17:38:51 UTC
A line has a stroke weight, which we inappropriately label as 'Width' as an attribute but not a height or a width. 

A line, as opposed to a point, has a length whcih we don't handle directly (although we probably should). Nor do we handle an area for a closed polygon.

Otherwise when laid down on canvas, it a line is inscribed inside a bounding box--described as its Position and Size. Setting width or height of a bounding box is meaningless as it describes just the end points of the line (as a line, a curve or a connector) not its attributes--stroke weight or thickness.

My take, "Position and Size" bounding box should keep the 'Width' and 'Height' of the shape object, while the "Line" attributes should be assigned 'Thickness', or possibly the more correct 'Weight'--remove the misnamed 'Width'.

But I do think line 'Thickness' rather than stroke 'Weight' would be an easier distinction for L10N.
Comment 6 Heiko Tietze 2022-12-08 08:38:35 UTC
We discussed the topic in the design meeting and suggest to follow Stuart's proposal to rename (line) "Width" into "Thickness".

Code pointer:
svx/uiconfig/ui/sidebarline.ui
cui/uiconfig/ui/linetabpage.ui
Comment 7 Commit Notification 2023-09-27 03:33:04 UTC
Adam Eric Fallon committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f20d1dad1b84367f8ec322690dae20b0defbb08

tdf#146609 Renamed line width to thickness.

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 BogdanB 2023-09-28 18:47:39 UTC
In the sidebar, instead of Line, Width, Color - we have Line, Thickness, Color. 

But I wonder if, for a line, the remaining "Width" field shouldn't be disabled, as in the video? A line with a width of 10 cm is a rectangle, it's not a line anymore.

Verified with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bbe4d3498c2f994342b4d213f0ae874e7b0b7775
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 9 Heiko Tietze 2023-09-29 08:20:35 UTC
(In reply to BogdanB from comment #8)
> A line with a width of 10 cm is a rectangle, it's not a line anymore.

If you add height to the discussion... but even then it affects the surrounding rectangle. Setting the exact line width is essential and should remain in the sidebar.
Comment 10 dainius.mazuika 2023-09-29 08:37:03 UTC
A line has these properties:
1. Thickness;
2. Length;
3. Start coordinates x/y;
4. End coordinates x/y;

Params 2, 3, 4 are derivatives from each other, param 1 is independent fro anything.

These four properties is the focus to the user, bounding box rectangle is not relevant at all but can be left also editable to geeky user.

Philosophical question "at what thickness the line becomes rectangle" is it off scope imo.

There are more independent parameters to add to mentioned 4: color, style, start shape (arrow, rectangle..), end shape.
Comment 11 Heiko Tietze 2023-09-29 10:03:02 UTC
(In reply to dainius.mazuika from comment #10)
> 2. Length;

A line in a rectangle of 2x2cm has a length of sqr(4). Dealing with width/height sounds easier to me.

Anyway, if anyone believes Position > Width/Height needs to be changed too, please file a new ticket. This was about Line > Width and became Thickness now.
Comment 12 Commit Notification 2023-10-06 13:40:02 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/a79a6e02003a1dd220e2c03add548758f928795b

tdf#146609 Rename line width to thickness in Help