Created attachment 177524 [details] A file with modified Default style, and several Heading N paragraphs In the attached document, edit Heading 2 style (e.g., right-click paragraph "2" and choose Paragraph->Edit Style). Go to dialog's Indents and Spacing tab. Press "Reset to Parent" button (in older versions, it was "Standard"). See that Indent Before text changes from 0 to 2 cm (because this is what defined at Default paragraph style in the document). Press OK. The paragraph 2 stays not indented. Opening the style's properties dialog again shows that the indent is still 0. Repro using Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 840b4eb2f3443ff883016e6a8a8ae49e9cbd9e4e CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL and also using OOo 3.2.0.
I confirm it with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: e27a41a362bf25e12487b36f625985b35fb891e3 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL perhaps duplicate of bug118225?
"Reset to Parent" calls function BaseFmtHdl which calls function Reset of the corresponding tab. There it does not distinguish between a FIRST call of a tab (changes ARE already applied) and a "Reset to parent" (changes ARE NOT applied). So this error does affect all dialogs using tabs using the "Reset" and "Reset to Parent" functionality if the ChangesApplied function is called in the reset function.
A simple bad fix would be just to remove the ChangesApplied function in [1] in the SvxStdParagraphTabPage::Reset function leading to obsolete get_state_changed_from_saved calls in FillItemSet until the changes are applied. Other solutions would include some flag in the reset page or creating and calling a new function for "Reset To Parent" of the page being called. Mike what do you think? [1] https://opengrok.libreoffice.org/xref/core/cui/source/tabpages/paragrph.cxx?r=5af2041c#830
(In reply to Andreas Heinisch from comment #3) Sorry, I would need to dive deep to get the idea - could we please have a call maybe, where you could give me the necessary context? You could join IRC, and we could arrange a time convenient to you? Thank you very much for working on this!
Hi Mike, thank you very much for the help. I have time next week and I will join IRC for the details. Thank you.
So the problem lies way deeper than missing ranges in the dialog. The reset to parent functions in the dialog but does not get reflected in the paragraph (check the style inspector). As Mike mentioned it could be that the change in [1] caused the problem. [1] https://gerrit.libreoffice.org/c/core/+/147023
Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug