Bug 146800 - Linked libraries don't show source path in Macro Organizer
Summary: Linked libraries don't show source path in Macro Organizer
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
7.1.8.1 release
Hardware: All Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: Macro-UI
  Show dependency treegraph
 
Reported: 2022-01-16 20:13 UTC by edil
Modified: 2024-08-30 04:58 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Old Macro Organizer with path and new with no path (27.40 KB, image/png)
2022-01-16 20:13 UTC, edil
Details
demo of what I see in basic macro organizer library tab and tooltip enhancement (260.02 KB, video/x-matroska)
2024-08-23 20:12 UTC, Jim Raykowski
Details
demo of what I see using qt5 VCL plugin (138.91 KB, video/x-matroska)
2024-08-24 05:18 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description edil 2022-01-16 20:13:53 UTC
Created attachment 177586 [details]
Old Macro Organizer with path and new with no path

In LO version 5 i used to wiew the path of the linked libraries in Macro Organizer.
Now i don't see that, but only the library name.
Comment 1 Andreas Heinisch 2022-01-20 13:54:22 UTC
Imho valid enhancement
Comment 2 Andreas Heinisch 2023-03-11 10:10:07 UTC
So folder names can be quite long for the macros and I would not overload the macro library form. How about a tooltip if you hover an item in the organizer?
Comment 3 edil 2023-03-12 21:01:03 UTC
May be a valid solution. When develop a library, obviously  it is important to understand if you are coding  e saving a user library or a linked library. Thank you
Comment 4 Jim Raykowski 2024-08-23 20:12:51 UTC
Created attachment 195988 [details]
demo of what I see in basic macro organizer library tab and tooltip enhancement

Hello,

I came across this bug while searching if a request has been made for a macro description tooltip in the Macro Selector dialog when the mouse pointer is over an entry in the Macro Name list box.

For me display of the link library file location seems to work. I am only beginning to explore this part of the codebase and don't have much experience with macro doings in LO so maybe I am missing what is not working here anymore.

While looking at the area of this code I added a tooltip to show the same information as what is shown in the second text column in the list. It seems to me to be a lot of repeated information but if it is useful to those who use this I will submit it.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d9841ab37825c220f887ff43ecab1522d770d5bd
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 Jim Raykowski 2024-08-24 05:18:26 UTC
Created attachment 195993 [details]
demo of what I see using qt5 VCL plugin

I noticed after sending the first demo that the gen and qt5 VCL plugin doesn't show the second column but does show the tool tip. I added some column headings to test if sizing the columns would make column 2 show and indeed it does.
Comment 6 Jim Raykowski 2024-08-29 03:35:58 UTC
Turns out the added tool tip code isn't required. A tool tip is automatically shown when the column entry text width is more than the column width.

Here is a patch that seems to fix the issue for VCL plugins that use SalInstanceTreeView:
https://gerrit.libreoffice.org/c/core/+/172560
Comment 7 Commit Notification 2024-08-30 04:55:26 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/41ad19c719decfdce1f26359277db6bb00002836

Resolves: tdf#146800 Linked libraries don't show shource path in Macro

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.