Bug 146937 - Is the "refresh" command needed in the Template Manager?
Summary: Is the "refresh" command needed in the Template Manager?
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Po-Yen Huang
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicDesign
Depends on:
Blocks: Template-Manager
  Show dependency treegraph
 
Reported: 2022-01-23 13:37 UTC by sdc.blanco
Modified: 2022-02-16 13:46 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
video of non refresing Manager (11.64 MB, video/webm)
2022-01-25 20:37 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-01-23 13:37:33 UTC
1. Open Template Manager (Ctrl+Shift+N)
2. Press "Manage" button (upper right corner)
3. Notice "Refresh" as option.

Question:  Is this command needed?

If not, then maybe it should be removed?

Question:  If it is needed, then what does it do?

It is not documented, but maybe it should be?

https://help.libreoffice.org/7.4/en-US/text/shared/guide/template_manager.html
Comment 1 Heiko Tietze 2022-01-24 09:34:50 UTC
I'm all in for lean UIs. The rare cases, cannot imagine any, could use a workaround.
Comment 2 BogdanB 2022-01-25 20:21:30 UTC
I supose if in the past the list was not asyncronous it was useful to have new templates, new categories. I will play with it to test if something is wrong when NOT used.
Comment 3 BogdanB 2022-01-25 20:29:28 UTC
I tried to import a new template, and if I want to remove it after that I need to try for 3-4 times in order to succeed. Refresh doesn't help, but maybe was helpful some time ago for things like that, and now is disconected.
Comment 4 BogdanB 2022-01-25 20:37:19 UTC
Created attachment 177788 [details]
video of non refresing Manager

Version: 7.3.1.0.0+ / LibreOffice Community
Build ID: de15e8d4f2f2e5d10cb5d9203e51f3a28347db8d
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 5 Heiko Tietze 2022-01-28 11:03:25 UTC
Let's kill it with fire.

Code pointer: sfx2/source/doc/templatedlg.cxx

* #define MNI_ACTION_REFRESH   "refresh"
* mxActionBar->append_item(MNI_ACTION_REFRESH, SfxResId(STR_ACTION_REFRESH), BMP_ACTION_REFRESH);
* MenuSelectHdl

include/sfx2/strings.hrc
* STR_ACTION_REFRESH

sfx2/inc/bitmap.hlst
* inline constexpr OUStringLiteral BMP_ACTION_REFRESH = u"res/reload.png";
Comment 6 Buovjaga 2022-01-28 11:28:41 UTC
Help file that will also need to be updated: source/text/shared/guide/template_manager.xhp
Comment 7 Po-Yen Huang 2022-02-07 07:10:00 UTC
https://gerrit.libreoffice.org/c/core/+/129584
Commit pushed, please review :-)
Comment 8 Commit Notification 2022-02-09 06:13:45 UTC
Jeff Huang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3e5e0c2943e057873952b5394b81dbe6d29ef1e2

tdf#146937 Remove "refresh" command from Template Manager

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Po-Yen Huang 2022-02-09 07:01:36 UTC
For help files: https://gerrit.libreoffice.org/c/help/+/129703
Please review and merge it :-)
Comment 10 Commit Notification 2022-02-16 13:46:39 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/0fa83de4173e9dfaaca3b3c288ec4843d15b9252

tdf#146733 (Related to: tdf#146937) remove "refresh" from help