Bug 146971 - FILEOPEN: performance regression (gtk3)
Summary: FILEOPEN: performance regression (gtk3)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.0 target:7.2.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-01-24 16:42 UTC by Xisco Faulí
Modified: 2022-01-25 18:10 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-01-24 16:42:29 UTC
Steps to reproduce:
1. Open attachment 177756 [details] from bug 139974 using "time OOO_EXIT_POST_STARTUP=1"

it takes

real	0m18,885s
user	0m18,364s
sys	0m0,660s

while it should take around 2 seconds

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 0c3b8792b712e939d2ad524d554f96616b4844be
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2022-01-24 16:48:25 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c9b19f69e658f1114f1b8fc0ae62b6edd6d33e3f

author	Caolán McNamara <caolanm@redhat.com>	2021-09-22 16:26:00 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2021-09-22 20:20:09 +0200
commit c9b19f69e658f1114f1b8fc0ae62b6edd6d33e3f (patch)
tree 54abb292cc80180e7b9442661d10a5e072a2dfb1
parent 7885c1cb80568930270e55b3ae450eccc66aca94 (diff)
Resolves: tdf#142704 %PRODUCTNAME shown in gtk3 extended tips

Bisected with: bibisect-linux64-7.3
 
Adding Cc: to Caolán McNamara
Comment 2 Caolán McNamara 2022-01-24 19:59:47 UTC
I presume by querying the a11y in order to change the %PRODUCTNAME we sparked it into life and carry the overhead of prematurely existing a11y
Comment 3 Commit Notification 2022-01-25 08:33:09 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/97cf76e9197a244a7d12f1f0a52074ccf36685e2

tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issues

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2022-01-25 08:34:52 UTC
that should resolve it. Done in trunk, backport to 7-3 and 7-2 in gerrit
Comment 5 Commit Notification 2022-01-25 09:10:51 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/4723360671758c3ac9e646382751d01b630a95d0

tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issues

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2022-01-25 10:10:35 UTC
Verified in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 5a1c19624eda0c8b847af0dcee70b82502578ceb
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!!
Comment 7 Commit Notification 2022-01-25 10:46:21 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/a6827c3787f3056444586979750f97d3e963f6f2

tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issues

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-01-25 12:24:10 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/be7c21cc6a8df1c06a3210f32322eab382834b72

Related: tdf#146971 rename %PRODUCTNAME Macros to Application Macros

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-01-25 12:24:20 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/e1da23a649197d960c8492373326e11286b3239e

Related: tdf#146971 rename %PRODUCTNAME Macros to Application Macros
Comment 10 Commit Notification 2022-01-25 12:25:28 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c7fcd5a3bdbf181817ce6e5d2067434d480287a6

Related: tdf#146971 remove %PRODUCTNAME from accessible-description

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-01-25 18:09:59 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-0":

https://git.libreoffice.org/core/commit/fb90ac4c621457786f64da4a69e515ea92fa30f3

tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issues

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.