The SAL_N_ELEMENTS() macro is defined in 'include/sal/macros.h'. It calculates the number of elements in an array at compile time. According the comments, "the argument must be an array and not a pointer". These are some examples from the above file: SAL_N_ELEMENTS("foo"); char aFoo[]="foo"; SAL_N_ELEMENTS(aFoo); This macro, uses sizeof() operator to calculate the "sizeof (arr) / sizeof ((arr)[0]))". Now we can use std::size() instead of SAL_N_ELEMENTS() macro. The result would be constexpr, compile-time constant expression. As an example, this code: for (unsigned i = 0; i != SAL_N_ELEMENTS(aFoo); ++i) { ... } can be converted into this one: for (unsigned i = 0; i != std::size(aFoo); ++i) { ... } One pitfall would be comparing the result with a signed value. Then, either you have to cast the result to a signed value, or use an unsigned value for the other side of the comparison.
(In reply to Hossein from comment #0) > One pitfall would be comparing the result with a signed value. Then, either > you have to cast the result to a signed value, or use an unsigned value for > the other side of the comparison. If there's need, we can make available C++20 > template<class T, ptrdiff_t N> constexpr ptrdiff_t ssize(const T (&array)[N]) noexcept; as o3tl::ssize for the time being. (Also, if it is known that the other side of the comparison, even though of signed type, must be non-negative, like e.g. a call to OUString::getLength, then o3tl::make_unsigned from o3tl/safeint.hxx is a good choice.)
Note also, that there are cases where std::size can't give a compile-time constant, unlike the SAL_N_ELEMENTS macro. That may be e.g. when a class contains an array member, and a static_assert checks the array dimension in its constructor. In that case, a "'this' can't be used in constant expression" error would result after the replacement. Usually, there's a way to restructure such cases, to avoid use of static asserts, and ensure the tested invariant some other way.
VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8b327cd86d71d71d2f5f883321e5d53e3b42ed4e tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hossein committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a5c6fbe247ee9f9b2fba828d1360748c3fe4642b tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #4) > Hossein committed a patch related to this issue. > It has been pushed to "master": This is an example for changing the type of the variable to a suitable unsigned type. https://git.libreoffice.org/core/commit/a5c6fbe247ee9f9b2fba828d1360748c3fe4642b The signed loop index variable of type 'int' is converted into 'size_t' to match the return value of std::size() which is unsigned
Gautham Krishnan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/51fb84829afbc1c0957fd1a489085613ad199f1a tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
psidiumcode committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5b320aa058504becae6ac6746926b481b326a24d tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sinduja Y committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a40ed687a3e2f8e1d17705fcd7d397ba09398cb6 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pragat Pandya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6abc09926c9b55a445b906303f56c6ec7fdeabf9 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman Kuznetsov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d694b572c7262a326ac7ceac2e558f3fc6c78df4 tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman Kuznetsov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/81aad6d53fa792dd95732e401ecb298714f699f4 tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
jsala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2c68c419c1fce6de1a81e1f13a84b7069125a204 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5b04eed4d22c9e3caa76e195582b15862e9261b6 tdf#147021 Use std::size in {Read,Write}JobSetup It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Re-evaluating the EasyHack in 2022 This issue is still relevant. There are still several instances of SAL_N_ELEMENTS() macro in use: $ git grep SAL_N_ELEMENTS|wc -l 1897
ehsan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e010a57ab2489464719fb73ad0aea6e4e4c60383 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
jsala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9e7e95a57b7c16941d9fdc59f806c1f9e4263379 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
jsala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/35a7e40d372d3211061465346825cf543a095f6d tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
jsala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8dc57426c3bd3385c30b9007991af8496b315f9a tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Radhey Parekh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/feb8d07333544ff2206489b786b7af30744d014a tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tomoyuki Kubota committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/86498bcd73050e44ea5ea53c384edb0baf033d16 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
jsala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b26793b907ce823e5cce38f6fe93b420ebe38579 tdf#147021 REVERT Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Let's keep the default assignee, as this is a generic task that can be worked on by several different contributors.
(In reply to Aron Budea from comment #22) > Let's keep the default assignee, as this is a generic task that can be > worked on by several different contributors. Understood, thank you for your help
OmkarAcharekar committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/75e6ffe31d74ac36d8864b018008d4208a7efe73 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
insanetree committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/07b6e34397037722d40b2013eef21085eca4f235 tdf#147021: SAL_N_ELEMENTS changed to std::size It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
jsala committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/04a58d7eae2b26559efd48ff7cdd23cec1c2187c tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Leonid Ryzhov committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/49737dff4b7b46c44f8c8e1c4de0291309eef78e tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vinit Agarwal committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d898620cb47e0d794d4033fdfa13b049f972a9ff tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dr. David Alan Gilbert committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4998370216bbea3bcaff7fac2d62cbb4ac978c5d tdf#145538,tdf#147021: sw/source: range based loops It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dr. David Alan Gilbert committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7bec1689fcbe9102aa220739b6113118d9a8dd1f tdf#145538,tdf#147021: qa: range based loops It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dr. David Alan Gilbert committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9bc3c4fa8d380bd7ae5689692cc80f815bed4707 tdf#147021: sw/source use std::size() instead of SAL_N_ELEMENTS It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dr. David Alan Gilbert committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/880bc4255099132557fe8d7d36a50c06f05cf5a1 tdf#147021: vcl/* KeyboardReplacements SAL_N_ELEMENTS removal It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Dr. David Alan Gilbert committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c437ccaab235320995af8c272705ac7c01784dd8 tdf#147021: sc/source/filter SAL_N_ELEMENTS usage It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'd appreciate review on: https://gerrit.libreoffice.org/c/core/+/153889 which takes out a chunk of the SAL_N_ELEMENTS using span types. (Large but mostly mechanical)
sahil committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0c45d90cfb1cc60218fbce3743df442b1f1d3f70 tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Adam Seskunas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b1b002c293ddf38be125dc9083f41eb27452c450 tdf#147021 use std::size instead of SAL_N_ELEMENTS It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.