Bug 147042 - Manage Changes sidebar in Writer no longer needs to be an experimental feature
Summary: Manage Changes sidebar in Writer no longer needs to be an experimental feature
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.2.2 release
Hardware: All All
: medium enhancement
Assignee: Rafael Lima
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks:
 
Reported: 2022-01-28 14:11 UTC by Rafael Lima
Modified: 2022-02-14 11:43 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-01-28 14:11:54 UTC
LibreOffice Writer has a dialog for managing changes in the document that can be accessed in Edit - Track Changes - Manage.

There's also a very handy Manage Changes sidebar that shows the same dialog, which makes it easy to navigate changes in the document. However, this sidebar is marked as an Experimental Feature. See:

https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu?r=656ed2c6#245

IMO there's no need to keep this as experimental since it relies on a feature that is already available and functional in LibreOffice. So I propose to make this sidebar enabled by default.
Comment 1 Heiko Tietze 2022-01-31 12:35:43 UTC
Kendy, IIRC it was your work. What do you think?
Comment 2 Jan Holesovsky 2022-02-01 16:43:50 UTC
Oh it it still works well even thought it was experimental for a long time, I'd be very happy to see it enabled of course!  IIRC I've done the code so that it reuses the dialog's content as much as it can, so probably that effort has paid off :-)
Comment 3 Heiko Tietze 2022-02-03 09:08:53 UTC
So let's do it. 

Code pointer: officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu: <node oor:name="SwManageChangesDeck"... <prop oor:name="IsExperimental" = true. This node can just be deleted.
Comment 4 László Németh 2022-02-10 15:30:30 UTC
(In reply to Heiko Tietze from comment #3)
> So let's do it. 
> 
> Code pointer: officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu:
> <node oor:name="SwManageChangesDeck"... <prop oor:name="IsExperimental" =
> true. This node can just be deleted.

FYI: enabling the Manage Changes sidebar stops tracking of row deletion (see https://wiki.documentfoundation.org/ReleaseNotes/7.3#Tracked_table_row_deletion.2Finsertion). Likely the recent unit tests won't catch the problem, because the problem raised by the first activation of the Manage Changes panel on the sidebar.
Comment 5 Heiko Tietze 2022-02-10 16:01:42 UTC
(In reply to László Németh from comment #4)
> FYI: enabling the Manage Changes sidebar stops tracking of row deletion...

Don't understand why this happens since the sidebar deck copies the dialog more or less. But do you suggest to wait until the issue is fixed? If so, is there a schedule?

Patch is submitted, waiting for the final keypress  https://gerrit.libreoffice.org/c/core/+/129477
Comment 6 Commit Notification 2022-02-14 11:43:40 UTC
rafaelhlima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bf5277500d0d317a24df66f81b7409301f8422a6

tdf#147042 Manage changes sidedbar no longer needs to be experimental

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.