Bug 147053 - Add Aranese {oc-ES} locale data
Summary: Add Aranese {oc-ES} locale data
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
(earliest affected)
Hardware: All All
: medium enhancement
Assignee: Javier
Whiteboard: target:7.4.0
Depends on:
Reported: 2022-01-29 09:12 UTC by Javier
Modified: 2022-02-12 16:54 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Note You need to log in before you can comment on or make changes to this bug.
Description Javier 2022-01-29 09:12:02 UTC
I am a novice programmer working on several Aranese (Occitan) related projects. I would like to collaborate with libreoffice by defining a new (Aranese) oc-ES location, although I don't know what steps I should follow.

Thank you.
Comment 1 Julien Nabet 2022-01-29 09:59:31 UTC
You can start here:

First steps are:
- retrieve source code
- build locally

- send ad hoc license statement
- submit a patch

Here are 2 commits about adding some location which may interest you:
1) https://cgit.freedesktop.org/libreoffice/core/commit/?id=3480a1812d28c5d7e60bbec43f22af823234866a
2) https://cgit.freedesktop.org/libreoffice/core/commit/?id=083c93d406a9653922e9510509333f7ee64049fa
Comment 2 Eike Rathke 2022-01-29 10:39:53 UTC
For how to contribute locale data please see

The locale data file can probably similar to the pdc-US case (1 linked by Julien) defining the translatable items, just here inheriting from es_ES instead of en_US.

The language list entry already exists, so 2) is not needed.
Comment 3 Javier 2022-01-30 08:42:09 UTC
I've tried uploading the changes but it seems I don't have permissions.

diff --git a/i18npool/Library_localedata_es.mk b/i18npool/Library_localedata_es.mk
index cd0b74f151ee..5b6cdd3bcc29 100644
--- a/i18npool/Library_localedata_es.mk
+++ b/i18npool/Library_localedata_es.mk
@@ -36,6 +36,7 @@ $(eval $(call gb_Library_add_generated_exception_objects,localedata_es,\
        CustomTarget/i18npool/localedata/localedata_es_UY \
        CustomTarget/i18npool/localedata/localedata_es_VE \
        CustomTarget/i18npool/localedata/localedata_gl_ES \
+       CustomTarget/i18npool/localedata/localedata_oc_ES \
 # vim: set noet sw=4 ts=4:
diff --git a/i18npool/source/localedata/data/oc_ES.xml b/i18npool/source/localedata/data/oc_ES.xml
new file mode 100644
index 000000000000..45bfd4c0784e
--- /dev/null
+++ b/i18npool/source/localedata/data/oc_ES.xml
@@ -0,0 +1,371 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!DOCTYPE Locale SYSTEM 'locale.dtd'>
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed

ente@FIJO:/ssd/soft/libreoffice/libreoffice2$ git push
Username for 'https://gerrit.libreoffice.org': javierde22@hotmail.com
Password for 'https://javierde22@hotmail.com@gerrit.libreoffice.org': 
remote: Unauthorized
fatal: Autenticación falló para 'https://gerrit.libreoffice.org/core/'
Comment 4 Julien Nabet 2022-01-30 08:59:21 UTC
You must use ./logerrit submit (from LO core directory), not git push.

To test if everything is ok with your gerrit account, try:
./logerrit test
It should return:
"Your gerrit setup was successful!"

You may find extra info https://wiki.documentfoundation.org/Development/gerrit/setup ?

Also, do no forget https://wiki.documentfoundation.org/Development/GetInvolved#License_statement
Comment 5 Javier 2022-01-30 10:57:36 UTC
I have been looking at the code and the Aranese language is partially defined.

Is already defined

FILE ./svtools/inc/langtab.hrc

FILE ./include/i18nlangtag
#define LANGUAGE_USER_OCCITAN_ARANESE       LanguageType(0x8082)

Remains to be defined

FILE ./i18nlangtag/source/isolang
    { LANGUAGE_USER_OCCITAN_ARANESE,        "oc", "ES", k0    },
FILE ./i18npool/Library_localedata_es.mk
	CustomTarget/i18npool/localedata/localedata_oc_ES \

FILE ./i18npool/source/localedata/localedata.cxx
    { "oc_ES",  lcl_DATA_ES },
add the file

I already have the oc_ES.xml file defined on my computer

I already submitted the ad hoc license declaration

Then I have configured the private key on my pc and the public key on the web.

but when I execute 
./logerrit test

The command fails
There seems to be trouble. Please have the output of:
ssh -vvvv logerrit
at hand when looking for help.

debug1: Will attempt key: /home/ente/.ssh/id_ed25519 ED25519 SHA256:############ explicit
debug2: pubkey_prepare: done
debug3: send packet: type 5
debug3: receive packet: type 6
debug2: service_accept: ssh-userauth
debug1: SSH2_MSG_SERVICE_ACCEPT received
debug3: send packet: type 50
debug3: receive packet: type 51
debug1: Authentications that can continue: publickey
debug3: start over, passed a different list publickey
debug3: preferred gssapi-with-mic,publickey,keyboard-interactive,password
debug3: authmethod_lookup publickey
debug3: remaining preferred: keyboard-interactive,password
debug3: authmethod_is_enabled publickey
debug1: Next authentication method: publickey
debug1: Offering public key: /home/ente/.ssh/id_ed25519 ED25519 SHA256:############ explicit
debug3: send packet: type 50
debug2: we sent a publickey packet, wait for reply
debug3: receive packet: type 51
debug1: Authentications that can continue: publickey
debug2: we did not send a packet, disable method
debug1: No more authentication methods to try.
javierde22@hotmail.com@gerrit.libreoffice.org: Permission denied (publickey).

Sorry for asking so many questions but I've tried everything I can think of.

Can you help me?

Comment 6 Eike Rathke 2022-01-30 13:06:01 UTC
(In reply to Julien Nabet from comment #4)
> You must use ./logerrit submit (from LO core directory), not git push.
Actually one can use git push, ./logerrit submit doesn't do anything else just a little more convenient, but then use the correct command form to push to the gerrit review branch, i.e.
git push ssh://logerrit/core HEAD:refs/for/master


(In reply to Javier from comment #5)
> Remains to be defined
> FILE ./i18nlangtag/source/isolang
>     { LANGUAGE_USER_OCCITAN_ARANESE,        "oc", "ES", k0    },
That also is already there:

> Then I have configured the private key on my pc and the public key on the
> web.
With "on the web" you mean you created a TDF SSO account and registered with Gerrit and can sign in to Gerrit using SSO and uploaded your pubkey there?
See https://wiki.documentfoundation.org/Development/gerrit/setup#Setting_yourself_up_for_gerrit

> debug1: Will attempt key: /home/ente/.ssh/id_ed25519 ED25519
I'm not sure ED25519 keys can be used to authenticate.. documentation always talks about RSA keys.
Anyhow, Bugzilla isn't the best medium to discuss such and help. Probably best is to join IRC, see Troubleshooting help of the wiki link above. Chances to get timely responses are best during weekdays European work time.

If everything else fails you can also attach your patch here and I'll review and commit it when good; export from your git tree with
git format-patch -1
and attach the resulting file to this bug using type patch.
Comment 7 Eike Rathke 2022-02-03 16:00:25 UTC
Javier, do you need help with squashing the change of
https://gerrit.libreoffice.org/c/core/+/129186 into
and resubmitting it as an amended commit?
Or help with the details I lined out in my comments to
https://gerrit.libreoffice.org/c/core/+/129178 ?
Comment 8 Eike Rathke 2022-02-08 23:43:25 UTC
I uploaded the squashed commit and changes as new patch set of
Please check the two commented items there.
Comment 9 Commit Notification 2022-02-12 16:53:21 UTC
javierde22 committed a patch related to this issue.
It has been pushed to "master":


Resolves: tdf#147053 Add Aranese {oc-ES} locale data

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.