Bug 147325 - Unable to 'Tab' when writing SQL in 'SQL View'
Summary: Unable to 'Tab' when writing SQL in 'SQL View'
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.2.6 target:7.3.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-02-09 17:21 UTC by Dreamquartz
Modified: 2022-02-23 16:09 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dreamquartz 2022-02-09 17:21:21 UTC
LO 6.4.7.2 allows the use of 'Tab' and 'Double Quotes' in 'SQL View' for writing SQL Queries.
This is the last version of LO where this is possible.
Since the LO 7 series both are not available for use in 'SQL View' anymore.

On page 46 of BG64-BaseGuide.pdf and clearly repeated on page 207 of BG72-BaseGuide.pdf, there is a notation method of field names between double quotes, like “sportage” and “Loan”.
The User can assume that this is a valid method to be used for writing queries over time and can still be used ‘today’ (as of the date of describing this issue).

Writing and Editing a Query can now only be done outside 'SQL View' while wanting to use both functions.

Having tried Safe Mode and New Profile, but same results for all of the LO 7 series, up to LO 7.3.0.

Dream

Using LO 6.4.7.2 on Ubuntu 20.04 LTS.
Experimenting with all LO 7 series.
Comment 1 Robert Großkopf 2022-02-10 07:11:29 UTC
Couldn't confirm it is working in another way. I'm writing here with Double Quotes without any problem.

But: could confirm Tab couldn't be used in direct SQL mode in queries since LO 7.1.

Tested with 
Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

and newer versions.
Works well in LO 7.0.5 on older versions.

Let us switch this one to the bug for setting Tabulators in a query. Feel free to open another bug for Double Quotes.
Comment 2 Aron Budea 2022-02-11 06:08:24 UTC
Bibisected to the following commit using repo bibisect-linux-64-7.1. Adding CC: to Caolán McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=44f7674ffda49257dcc1709256dfc4676d12165c
author		Caolán McNamara <caolanm@redhat.com>	2020-08-18 12:02:45 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2020-08-19 10:11:30 +0200

weld OQueryTextView
Comment 3 Commit Notification 2022-02-11 16:54:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a4b8925e57fa727c980157ebeef83100386c7444

Resolves: tdf#147325 "Edit in SQL View" should accept tab

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2022-02-11 16:55:39 UTC
done in trunk, backport to 7-3 and 7-2 in gerrit
Comment 5 Commit Notification 2022-02-11 18:58:31 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/422e0ad9fe102ac44466acc6a1748f967d61246b

Resolves: tdf#147325 "Edit in SQL View" should accept tab

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-02-11 18:58:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/67c3601b835febca282b2ff44137a18891a4fd0b

Resolves: tdf#147325 "Edit in SQL View" should accept tab

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-02-23 11:47:57 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-1":

https://git.libreoffice.org/core/commit/c741f4bf824802863699f067968830e94d77ad6f

Resolves: tdf#147325 "Edit in SQL View" should accept tab

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.