Bug 147393 - Chart - Format Data series - Spacing can not be enter as value, just with plus minus signs
Summary: Chart - Format Data series - Spacing can not be enter as value, just with plu...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.1 target:7.2.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2022-02-12 18:33 UTC by BogdanB
Modified: 2022-02-23 16:10 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
testing file (12.66 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-02-12 18:34 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BogdanB 2022-02-12 18:33:19 UTC
Description:
When I want to change a chart, double click the chart, click on bars and Format data series - Option, the spacing could NOT be change by entering the value, but just with plus or minus signs.

Maybe is just a gtk3 bug.

Regression from 7.2

Steps to Reproduce:
1. Open my odf file. Edit the chart bars. 
2. Format data series - Options
3. Try to change Spacing

Actual Results:
It's possible just from +- signs

Expected Results:
It's possible to enter a value inside the field


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 1 BogdanB 2022-02-12 18:34:30 UTC
Created attachment 178241 [details]
testing file

Could be reproduce on any new file, in any 2D chart.
Comment 2 raal 2022-02-12 22:25:54 UTC
Confirm Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 1c0aa970650ffc7c749e0b5ea655ebb2d137c8ae
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo
Comment 3 raal 2022-02-12 22:40:45 UTC
It works with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 1c0aa970650ffc7c749e0b5ea655ebb2d137c8ae
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: x11
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo


Adding cc to Caolán, maybe you're interested.
Comment 4 BogdanB 2022-02-13 10:50:22 UTC
Could be a weld problem if is just gtk3.
Comment 5 Aron Budea 2022-02-18 05:08:47 UTC
(In reply to BogdanB from comment #0)
> Regression from 7.2
If you think it's a regression, please add the keywords regression and bibisectRequest, and a known working version.

My result is that this is a regression from 6.2, and could be bibisected to the following commit using the respective bibisect repo.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8947c9b1d8cd407131fdfb6fc3c77c8532e9d2a0

author		Caolán McNamara <caolanm@redhat.com>	2018-10-18 13:00:41 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-10-20 13:52:34 +0200

weld SchAttribTabDlg
Comment 6 Commit Notification 2022-02-18 14:21:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0c76e951d53d5da56616442d7344b373add4afe2

Resolves: tdf#147393 SpinButtons should be can-focus

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2022-02-18 14:21:58 UTC
done in trunk, backport to 7-3 and 7-2 in gerrit
Comment 8 Commit Notification 2022-02-19 08:11:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/23ab6c3c42beff3d7436db8dede9330dbe870bcc

Resolves: tdf#147393 SpinButtons should be can-focus

It will be available in 7.2.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-02-19 08:11:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/a4a8eff788919ce9a2f458e1b0e3393547be7954

Resolves: tdf#147393 SpinButtons should be can-focus

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 BogdanB 2022-02-22 04:45:49 UTC
Thanks Caolan.
Verified in Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 0723b41bed9bb4ad50d2993744a60177966d1a21
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 11 Commit Notification 2022-02-23 10:22:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-1":

https://git.libreoffice.org/core/commit/2af6f132ee199c000fd1bd0e6efebff473b6ea47

Resolves: tdf#147393 SpinButtons should be can-focus

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-02-23 10:22:18 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2-6":

https://git.libreoffice.org/core/commit/46d35b2f3d89292ef4ae2e21ae649f6b332ac881

Resolves: tdf#147393 SpinButtons should be can-focus

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.