Bug 147555 - Track Changes: Reject highlighting doesn't remove highlighting
Summary: Track Changes: Reject highlighting doesn't remove highlighting
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes
  Show dependency tree / graph
 
Reported: 2022-02-20 18:26 UTC by Telesto
Modified: 2022-09-14 04:16 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (9.40 KB, application/vnd.oasis.opendocument.text)
2022-02-20 18:26 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-02-20 18:26:01 UTC 
Description:
Track Changes: Reject highlighting doesn't remove highlighting

Steps to Reproduce:
1. Open the attached file
2. Select "Nunc'
3. Press CTRL+B
4. Select "pharetra" 
5. Press Character Highlighting button
6. Edit -> Track Changes -> Manage
7. Press Reject (2x)

Actual Results:
Yellow highlighting still present

Expected Results:
Unformatted text


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2bb10a827ac13d0caf009e8526ccd9f17dc71653
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL Jumbo
Comment 1 Telesto 2022-02-20 18:26:11 UTC 
Created attachment 178411 [details]
Example file
Comment 2 Telesto 2022-02-20 18:32:43 UTC 
Working properly in
Version: 7.0.0.0.beta1+ (x64)
Build ID: 2891e91a513520d68ea2b8c59c14335861a15253
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
Version: 6.4.0.0.alpha0+ (x64)
Build ID: c56bf1479cc71d1a2b0639f6383e90c1f7e3655b
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

not OK in 
6.2.9 and older
Comment 3 Michael Warner 2022-02-21 18:54:08 UTC 
Repro in:

Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 10; OS: Mac OS X 10.16; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

and:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: e9332dcdc8f2ea268d1b17c73d43a8834cf75365
CPU threads: 10; OS: Mac OS X 12.2; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Occurs when previous operation before highlighting is formatting with bold or italic (like in the steps to reproduce), however it does not happen when the previous operation was inserting or removing a character. In other words, this works:

1. Open the attached file
2. Insert "a"
3. Select "pharetra" 
4. Press Character Highlighting button
5. Edit -> Track Changes -> Manage
6. Press Reject (2x)
Comment 4 Timur 2022-09-12 12:54:40 UTC 
Repro 7.5+ Windows, but not in Linux.
Comment 5 raal 2022-09-14 04:16:20 UTC 
Bisected to
 34d7d0525f4158e505f2d7c73bcbe1114e99a927 is the first bad commit
commit 34d7d0525f4158e505f2d7c73bcbe1114e99a927
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Mon Aug 16 06:14:40 2021 -0700

    source 0115a77eb84afb0d820d8e23f45e49b30b82a8d3

https://gerrit.libreoffice.org/c/core/+/120466