Bug 147640 - Linear gradient should not show settings for radial/non-linear gradients in Sidebar (GTK3)
Summary: Linear gradient should not show settings for radial/non-linear gradients in S...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.4.4 target:7.5....
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2022-02-24 14:27 UTC by R. Green
Modified: 2022-12-16 08:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Draw file demonstrating issues with gradient transparency (10.05 KB, application/vnd.oasis.opendocument.graphics)
2022-02-24 14:27 UTC, R. Green
Details
Screenshot of dialog I tested (90.05 KB, image/png)
2022-02-25 06:29 UTC, Rainer Bielefeld Retired
Details
Screenshot of sidebar "Area" dialog. (8.27 KB, image/png)
2022-02-25 09:57 UTC, R. Green
Details
Screenshot of side bar (12.26 KB, image/png)
2022-02-25 14:37 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description R. Green 2022-02-24 14:27:34 UTC
Created attachment 178512 [details]
Draw file demonstrating issues with gradient transparency

Version: 7.1.5.2 / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

1. Open the attached draw file and select the rectangle.
2. Click on "Gradient Transparency" down-arrow to open the dialog.
3. Try to adjust either of Centre-X or Centre-Y bu using the plus/minus controls.

UNEXPECTED RESULT (bug): This section of the dialog disappears.

4. Close and reopen dialog. Now try to adjust "Angle" by adjusting the plus/minus controls.

UNEXPECTED RESULT (bug): The top section of the dialog disappears and the angle value starts changing by itself at speed!

5. Close and reopen dialog. Now try to adjust "Start value" or End value" by adjusting the plus/minus controls.

UNEXPECTED RESULT (bug): The "Angle" part of the dialog disappears and the Start/End value starts changing at speed by itself!
Comment 1 R. Green 2022-02-24 14:37:05 UTC
AFAICS, this issue affects only linear gradients, for some reason.
Comment 2 Regina Henschel 2022-02-24 17:53:36 UTC
(In reply to R. Green from comment #0)
> Created attachment 178512 [details]
> Draw file demonstrating issues with gradient transparency
[] 
> 1. Open the attached draw file and select the rectangle.
> 2. Click on "Gradient Transparency" down-arrow to open the dialog.
> 3. Try to adjust either of Centre-X or Centre-Y bu using the plus/minus
> controls.

It is not clear, what part of the UI do you use. Please attach a screenshot.
For me, in the side bar there is no Center-X or Center-Y at all and in Format > Area > Transparency the controls for Center-X and Center-Y are disabled.
Comment 3 Rainer Bielefeld Retired 2022-02-25 06:29:46 UTC
Created attachment 178529 [details]
Screenshot of dialog I tested

NOT reproducible with reporter's sample document , Dialog as per screeenshot and Installation of Version: 7.3.0.3 (x64) 
Build ID 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win | Locale: de-DE (de_DE); UI: de-DE | Calc: threaded | ElementaryTheme | My normal User Profile

But I also am not sure whether reporter is talking about that specific dialog.
Comment 4 R. Green 2022-02-25 09:57:05 UTC
Created attachment 178534 [details]
Screenshot of sidebar "Area" dialog.

I forgot that there are two dialogs doing virtually the same thing.

The good (i.e. bug-free) dialog is the one you get by right-clicking on the rectangle and choosing "Area > Gradient".

The bad one (i.e. buggy) is the one in the SIDE BAR. See the attached screenshot. Just repeat the instructions in the OP with the sidebar dialog and the bug should become apparent.

(The right-click dialog has a more intuitive UI, IMO, but lacks the ability to vary the gradient transparency. Perhaps this should be incorporated)
Comment 5 Regina Henschel 2022-02-25 14:37:26 UTC
Created attachment 178539 [details]
Screenshot of side bar

Not reproducible with side bar in Version: 7.1.5.2 (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: threaded

>The right-click dialog has a more intuitive UI, IMO, but lacks the ability to
>vary the gradient transparency. Perhaps this should be incorporated.

It is already there. The full dialog that you get via item 'Area' in context menu or menu 'Format' has larger previews and therefor not enough room to put all on one tab. You find the transparency settings in tab "Transparency".
Comment 6 Alex Thurgood 2022-02-25 14:52:50 UTC
For comparison, no repro on macOS with 
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: beb6c62e990599d91ac5d9183164c94d269027d3
CPU threads: 8; OS: Mac OS X 10.16; UI render: Skia/Metal; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded


However, I do notice that it is impossible for a selected pair of colours in a gradient to be applied via the Area sidebar dialog in a selected shape, whereas the same selections function correctly and are applied when using the context menu of the shape.
Tested with 
Version: 7.2.5.2 / LibreOffice Community
Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5
CPU threads: 8; OS: Mac OS X 12.2.1; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

Don't know whether or not the above behaviour is related to this report.
Comment 7 Buovjaga 2022-12-15 13:03:05 UTC
Bibisected with linux-64-7.0 to https://git.libreoffice.org/core/commit/40fe5b93bc0838e04b46bfc7942d1ee6a2482ce0
weld AreaPropertyPanel

The center x/y are for non-linear gradients and should not be shown. However, after changing the type to radial, the same disappearance happened.
Comment 8 Caolán McNamara 2022-12-15 13:50:17 UTC
Doesn't happen under wayland, but does under X. Seems to be when the contents get relocated into the popup and without "no show all" set they get autoshown along with the new parent. Then disappear when the widget updates it values on user input.
Comment 9 Commit Notification 2022-12-15 16:39:36 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f26248a3ed8a089f15520d200a246ca6d5f3c50c

Resolves: tdf#147640 default optional grids hidden

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Caolán McNamara 2022-12-15 16:40:04 UTC
done in trunk, backports to 7-5 and 7-4 in gerrit
Comment 11 Commit Notification 2022-12-15 19:47:03 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/5fdca99850c02ee85e891d082af75cf5d820d115

Resolves: tdf#147640 default optional grids hidden

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-12-16 08:53:25 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/2c0532489601106183bbe64662ed2b5c78986199

Resolves: tdf#147640 default optional grids hidden

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.