Description: Warning dialog shows only once for "Record changes" in "Files" > "Properties" at "Security" tab. Steps to Reproduce: 1. Open "Files" > "Properties" dialog 2. Go to "Security" tab 3. Turn on and turn off "Record changes" 4. Turn on and turn off "Record changes" again Actual Results: Warning dialog shows only when "Record changes" turn off first time. Expected Results: Warning dialog shows when "Record changes" turn off every time. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.3.1.3 / LibreOffice Community Build ID: 30(Build:3) CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+xcb) Locale: zh-TW (zh_TW.UTF-8); UI: zh-TW 7.3.1-1 Calc: CL
Why? Should we assume that the user is not understanding it the first time, and will get it better the next time? They got the warning. They chose to read or to ignore it. Why should we force it again, when they do the same thing second time? What specific problem is this intended to solve?
(In reply to Mike Kaganski from comment #1) > Why? Should we assume that the user is not understanding it the first time, > and will get it better the next time? They got the warning. They chose to > read or to ignore it. Why should we force it again, when they do the same > thing second time? What specific problem is this intended to solve? Maybe we should add a "Do not show again" button or option to this (and maybe simliar) dialog.
Please describe what specific problem you intend to solve, that needs some changes. I.e., which scenario is harder now, that would become easier with the proposal implemented?
(In reply to Mike Kaganski from comment #3) > Please describe what specific problem you intend to solve, that needs some > changes. I.e., which scenario is harder now, that would become easier with > the proposal implemented? For those who click this checkbox twice or more times between a long interval, they may forget this warning and doubt why they are not reminded.
(In reply to Po-Yen Huang from comment #0) > Warning dialog shows only when "Record changes" turn off first time. True only if you keep the dialog open. If you close the properties dialog, open again, start and end recording again, you will get the warning. But another question is if we need this a warning at all. You deliberately uncheck the recording which of course should have the effect of stopping it. And it's also not a destructive or crucial option, neither the dialog tells me anything new. "This action will exit the change recording mode. No information about changes will be recorded from now on. Exit change recording mode?"
(In reply to Heiko Tietze from comment #5) I do not know for sure, but this option in the Security tab doesn't tell me clearly that this is not only about *protection* of the recording, but also about *controlling* (starting/stopping) it.
Furthermore, there is a difference in behaviour between Writer and Calc. In Writer, existing change-tracking persists and only future recording is stopped, while in Calc the existing change-tracking is discarded (it has to because of dependencies that would have to be created between existing data and future data but can't if recording is off) and the dialog doesn't mention that at all. Stopping recording in Calc via Edit -> Track Changes -> Record raises a dialog with "Any information about changes will be lost." (which in fact for the Yes button should have the destructive action red background but doesn't).
So resolve NAB/WF, Mike/Eike?
I'd rather suggest to add wording about the destructive nature of the action in the Calc case, but otherwise don't think that showing it more times while the Properties dialog is open would help anything..
The tooltip for this functionality says: "This is the same as Edit - Track Changes - Record". If that is the case - I would consider removing this checkbox entirely, since it is a selective record of changes, and should not be thought of as a security measure.
Switching Edit > TC > Record off as well as File > Properties > Security > Record reverts all TC from the sheet and you will not see any marking in Calc. Both workflows show the warning dialog. In Writer, switching Record off keeps the marked changes, ie. you have to accept/reject to "clean up". And the path via File > Properties shows the warning while Edit doesn't. I think we should align the workflows and do not show the warning in Writer for the File > Properties path. The warning in case of Calc could then be changed like "This action will exit the change recording mode. You will not be able to reject changes made. Exit change recording mode?"