Bug 147997 - MySQL/MariaDB: Dialog for direct connection should be changed from MySQL to MariaDB
Summary: MySQL/MariaDB: Dialog for direct connection should be changed from MySQL to M...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.1.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-15 07:49 UTC by Robert Großkopf
Modified: 2022-03-24 07:16 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Additional changes for MySQL/MariaDB dialog, step 2. (160.78 KB, image/png)
2022-03-20 16:35 UTC, Robert Großkopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2022-03-15 07:49:11 UTC
Since LO 6.2 the direct connection for MariaDB is included in LO:
https://wiki.documentfoundation.org/ReleaseNotes/6.2#Base

Start LO.
Click on "Base Database"
Connect to an existing database.
Choose MySQL (should be changed to MySQL/MariaDB)
Next (Step 2) → Connect directly (Step 2 should be changed from "Setup MySQL Connection" to …MySQL/MariaDB…)
Step 3 now declares to be a connection to MySQL, also the dialog declares to connect to MySQL. But the connection we are using is a MariaDB-connection.

Nobody cares about this, because there was no essential difference between MySQL and MariaDB when creating the direct connection with MariaDB. But with newer versions of MySQL the connection could be buggy together with MySQL. So we should show it is a MariaDB-connector we are using, not a MySQL-connector.

See, for example, https://bugs.documentfoundation.org/show_bug.cgi?id=143317
Comment 1 Julien Nabet 2022-03-15 19:47:45 UTC
I submitted this patch:
https://gerrit.libreoffice.org/c/core/+/131632
whatever if the patch is correct or not, the changes will only be on master branch (so future 7.4) I suppose since the patch will modify translations part.

Just personal opinion but ideally, I would have dumped "MySQL" and replaced it with "MariaDB" because the more MySQL and MariaDB will differ, the more we'll got some complaining about Mysql pbs. Of course, I'm talking about direct connection. About JDBC or ODBC connection, people will just have to deal with the ad hoc driver.
REALLY ideally I would have changed all filenames (mysqlc_catalog.cxx), prefix etc but 1) it's a lot of changes (so lots of time to spend and lots of possible regression) 2) I suppose it would be no-go for compatibility sake about odb files created with "mysql" reference.

(Thank you Oracle...)

Olivier: since you're the main "Documentation guy", thought you might be interested about this one. I noticed that there already were several locations where it's indicated "MariaDB or MySQL".
Comment 2 Commit Notification 2022-03-16 18:48:11 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f5c3b63b6fdcc7638a3a2683b2f58e6c15758385

tdf#147997: MySQL/MariaDB for dialog for direct connection

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Julien Nabet 2022-03-16 18:53:02 UTC
Robert: don't hesitate to reopen this tracker if I missed one.
Comment 4 Robert Großkopf 2022-03-16 18:58:34 UTC
(In reply to Julien Nabet from comment #3)
> Robert: don't hesitate to reopen this tracker if I missed one.

Thanks!

Will test it in one of the daily builds next week.
Comment 5 Robert Großkopf 2022-03-20 16:34:20 UTC
(In reply to Julien Nabet from comment #3)
> Robert: don't hesitate to reopen this tracker if I missed one.

Have had a look. Many of the items now contain MySQL/MariaDB. Added a screenshot with some changed I would add also.
Comment 6 Robert Großkopf 2022-03-20 16:35:10 UTC
Created attachment 178994 [details]
Additional changes for MySQL/MariaDB dialog, step 2.
Comment 7 Commit Notification 2022-03-24 07:16:09 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f80e618a79ac70bc6658771b64d018cd228200e

Related tdf#147997: connect directly dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.