Bug 148029 - Colibre Dark icons with dark background should be made transparent
Summary: Colibre Dark icons with dark background should be made transparent
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: low enhancement
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-16 10:45 UTC by Pedro
Modified: 2022-04-01 22:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Icons like the Print Preview, comments, shapes icons have dark backgrounds (113.98 KB, image/png)
2022-03-16 10:45 UTC, Pedro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro 2022-03-16 10:45:13 UTC
Created attachment 178912 [details]
Icons like the Print Preview, comments, shapes icons have dark backgrounds

Steps to reproduce:
In Master
1 - go to Options -> View -> Icon Style
2 - Select Colibre Dark.

Some of the icons included on Colibre dark have dark background inside the icons.
This might be a problem because dark themes of different DEs/OSes might use different shades of dark gray for their dark themes. Not to mention that users might install or use different dark themes such as Arc darker, Breeze Dark, Yaru, McMojave, Nordic, etc...
Thus I would propose that Colibre Dark uses transparent background on the icons with dark background so that the icons use the dark color from the selected themes.
Comment 1 Commit Notification 2022-03-17 15:02:24 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6898a115426de6c3142521587fa693914fbe553f

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2022-03-18 03:21:49 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/778bbcede813dd51e11ee61583247db1199eda63

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 steve 2022-03-18 12:47:30 UTC
Valid enhancement request. Setting to NEW
Comment 4 Commit Notification 2022-03-19 03:48:22 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/566ee17c2709f9939145ddc7fbb1d61c35049321

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-03-19 07:30:11 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/da3759155fcfe855dab99d59f3b9540efa9777d7

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-03-19 08:52:35 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/927cf43c07606c687f47831dcd70b57e52d52906

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-03-19 14:57:05 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d02f111181b0f79eda2a96f47181da5ee8d3aabf

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-03-21 07:09:58 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0ca27824bf6e84adcf7d481d232cbe28ff99cfae

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-03-21 14:38:49 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f8b482f6d601b40c0263333da393bc218c8114eb

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-03-22 14:59:14 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/931ce5db280ab7c4ccd005cc43f08a693dc34e9f

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-03-23 02:33:08 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/131a06fb2e414d8b8e49cd03c6b45f715047bad1

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-03-24 05:19:28 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/40a327857695d45c80f94b3c73e6b3599f96dcc0

Colibre: tdf#148029 Remove dark area in dark variant

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Rizal Muttaqin 2022-03-24 05:30:10 UTC
This bug has been resolved with update for over 5000+ files (https://github.com/rizmut/libreoffice-style-colibre/pull/45/files). Please feel free to reopen if anything remains.
Comment 14 Commit Notification 2022-03-26 22:27:57 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a59e2ffbd632585293195485bce19bbc3442f9c0

Colibre: tdf#148029 Change line only shapes with real intersected shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2022-03-27 00:37:29 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b15ae924e6c7e1ce9d69dc93e1b5afdb714ae2a9

Colibre: tdf#148029 Change line only shapes with real intersected shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2022-03-28 09:27:53 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2f2df626117380427d2e5e8417316f52823f1e6f

Colibre: tdf#148029 Change line only shapes with real intersected shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2022-03-28 19:56:58 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/91b45312b97ec272dfbbf5a01bd81d3db480e2aa

Colibre: tdf#148029 Change line only shapes with real intersected shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2022-03-31 03:51:40 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/aca4b5708207962935ca34adc70fed3a9ffb6074

Colibre: tdf#148029 Change line only shapes with real intersected shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2022-04-01 22:05:00 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f15a310ff4f13cd9e26d442a82f091176e3583c

Colibre: tdf#148029 Change line only shapes with real intersected shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.