Bug 148088 - UI: Dialog "Load Master Slide" should name "Load Master Page" (alongside several other similar labels)
Summary: UI: Dialog "Load Master Slide" should name "Load Master Page" (alongside seve...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.3.1.3 release
Hardware: All All
: medium normal
Assignee: Baole Fang
URL:
Whiteboard: target:7.6.0
Keywords: difficultyMedium, easyHack, skillCpp
Depends on:
Blocks: Dialog-UX
  Show dependency tree / graph
 
Reported: 2022-03-19 18:21 UTC by lol
Modified: 2023-05-25 04:47 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
draw dialog load master page (75.41 KB, image/png)
2022-03-19 18:21 UTC, lol 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lol 2022-03-19 18:21:55 UTC 
Created attachment 178971 [details]
draw dialog load master page

Steps:

1. Open Draw
2. Open the dialog via Page - Master Page... - Button load...
3. Dialog appears with the title "Load Master Slide"

Version: 7.3.1.3 (x64) / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
Comment 1 Buovjaga 2022-12-22 13:00:37 UTC 
Load Master Slide is STR_LOAD_PRESENTATION_LAYOUT in sd/inc/strings.hrc

Commit that did a similar change:
https://git.libreoffice.org/core/commit/5bc12e114fec50274580005647345a5392741ded

Other instances I noticed are "Rename Master Slide", STR_TITLE_RENAMEMASTER, which you can see in Draw by:
1. View - Master
2. Right-click a page in the page pane and select Rename Master

Change Slide Master... in the same context menu, the string for which is found in officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu

This opens a dialog called Available Master Slides, the string for which is found in sd/uiconfig/simpress/ui/slidedesigndialog.ui

The same dialog also has a label Select a Slide Design the string for which is found in sd/uiconfig/simpress/ui/slidedesigndialog.ui
Comment 2 Baole Fang 2023-05-07 22:00:55 UTC 
Start working on this
Comment 3 Commit Notification 2023-05-24 07:23:36 UTC 
Baole Fang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0a90b90048313fb43f8c5d7461f58dafec276600

tdf#148088: Fix master related UI in Draw

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 BogdanB 2023-05-25 04:47:47 UTC 
Baole, thanks for fixing this.

OK in
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 9a4b768b0a22bd3ae627c7355bbd223b9cf65015
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Was not ok in
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded