I found this issue when I tried to create a unittest for tdf#46338. In https://cgit.freedesktop.org/libreoffice/core/commit/?id=1135bfd78802e5c40ca09bcbc75d0908a423872a The behaviour was changed to show #NAME for invalid references ( e.g =SheetX.A1 ) However, in master Calc shows #REF! ( the old behaviour ) Reproduced in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 4a46a74a3de0ac7df5d3ce949dda5e809c1729ab CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded and Version: 6.3.0.0.alpha1+ Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: es-ES (es_ES.UTF-8); UI-Language: en-US Calc: threaded but not in Version: 6.1.7.0.0+ Build ID: 5b3765f4d881e7ddefd0c4aad6886a46f000b4fc CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: es-ES (es_ES.UTF-8); Calc: group threaded
@Eike, since you fixed bug 46338, I thought you might be interested in this issue
(In reply to Xisco Faulí from comment #0) > but not in > > Version: 6.1.7.0.0+ For some reason I could repro this back to 4.2, and bibisecting with bibisect-42max points to the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e247262327d04ad9933f4af354050f4420c6e303 author Kohei Yoshida <kohei.yoshida@gmail.com> 2013-07-26 00:41:07 -0400 committer Kohei Yoshida <kohei.yoshida@gmail.com> 2013-07-30 23:49:55 -0400 More on avoiding direct access to data members.
I might take a look.. (clarification: input of invalid sheet reference like =SheetX.A1 correctly results in #REF! error but reference in formula is (technically correct from how references work) also changed to =#REF!.A1 instead of preserving the original input, which originally the fix of bug 46338 addressed).
Fwiw, sc/qa/unit/ucalc_formula.cxx already indirectly tests the behaviour, which now changes with https://gerrit.libreoffice.org/c/core/+/135453/1/sc/qa/unit/ucalc_formula.cxx
Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/104596d005b32bd2bba15554e8c9ae740327aa46 Resolves: tdf#148163 Preserve names of bad cell reference input again It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/ea91f8f9b1bccce73a22af8b4c1626ccb834b9d1 Resolves: tdf#148163 Preserve names of bad cell reference input again It will be available in 7.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.