Bug 148168 - LibreOffice Document Recovery dialog shows weird text input field
Summary: LibreOffice Document Recovery dialog shows weird text input field
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
7.3.3.2 release
Hardware: All Linux (All)
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.5
Keywords:
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2022-03-24 22:14 UTC by skierpage
Modified: 2022-05-31 14:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
weird text input field over LibreOffice Document Recovery dialog (39.02 KB, image/png)
2022-03-24 22:15 UTC, skierpage
Details

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2022-03-24 22:14:48 UTC
Description:
When LibreOffice shows its Document Recovery dialog, if you start typing a text input field appears on it (see attachment), but it has no point and seems non-functional.


Steps to Reproduce:
1. Trigger the LibreOffice Document Recovery dialog
2. Type random characters.

Actual Results:
A little text field appears obscuring the dialog's buttons (see attachment), but it doesn't do anything.

Expected Results:
No text field should appear. The dialog does accept keystrokes, e.g. if I recall correctly Alt+S to start recovery.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
LibreOffice crashed while I was editing two temporary read-only Calc spreadsheets that I opened from ZIP files in KDE's Ark archiving tool. Editing read-only temporary files created by another program despite the warnings is probably a bad idea.
Comment 1 skierpage 2022-03-24 22:15:56 UTC
Created attachment 179091 [details]
weird text input field over LibreOffice Document Recovery dialog
Comment 2 Roman Kuznetsov 2022-05-20 19:46:51 UTC
Please write here info from your LibreOffice's Help-About dialog (use the Copy botton there)
Comment 3 skierpage 2022-05-21 03:26:30 UTC
(In reply to Roman Kuznetsov from comment #2)
> Please write here info from your LibreOffice's Help-About dialog (use the
> Copy botton there)

It still happens. I just reproduced with

Version: 7.3.3.2 / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 4; OS: Linux 5.17; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Flatpak
Calc: threaded

I'm running a KDE Wayland desktop; I think LO is using Wayland not XWayland.
Comment 4 Roman Kuznetsov 2022-05-21 11:40:58 UTC
No repro in

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: a2ffd71f20e14f797f30223fe29b3ac1e92eafdf
CPU threads: 4; OS: Linux 5.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: ru-RU (ru_RU.UTF-8); UI: ru-RU
Calc: threaded

Possibly Flatpack + gtk backend inside KDE Wayland problem >_<
Comment 5 Michael Weghorn 2022-05-23 15:19:04 UTC
I can reproduce with SAL_USE_VCLPLUGIN=gtk3 in both, a Plasma Wayland as well as a Plasma X11 session, but not with SAL_USE_VCLPLUGIN=gen or SAL_USE_VCLPLUGIN=kf5.

Haven't tested with other desktop environments, but I'd be rather surprised if it was related to KDE Plasma.

-> looks specific to the gtk3 VCL plugin

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: 30a048cb895a3dcdd6048f3c525edd95a1371b91
CPU threads: 12; OS: Linux 5.17; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 6 Caolán McNamara 2022-05-23 16:02:22 UTC
It's a search box, all GtkTreeViews (as used in this list) come with a search box enabled by default, typically defaulting search to column 0.

https://docs.gtk.org/gtk3/method.TreeView.get_enable_search.html

Its trivial for a dev to disable it in the relevant .ui, but maybe in this case its more useful to set it to search the column of "Document Name" instead of the column 0 which is just used to show an icon
Comment 7 Caolán McNamara 2022-05-23 16:47:14 UTC
lets try and make it do something useful as the first option
Comment 8 skierpage 2022-05-23 23:54:52 UTC
(In reply to Caolán McNamara from comment #6)
> It's a search box, ...
> Its trivial for a dev to disable it in the relevant .ui, but maybe in this
> case its more useful to set it to search the column of "Document Name"

Huh, I had no idea. It appears with no prompt or tooltip far from the column it's searching/filtering.

> lets try and make it do something useful as the first option

Rather than struggle to make it comprehensible, just remove it and wait for anyone to request "a way to search through the dozens of recovered documents in my Document Recovery dialog". I've never had more than a handful.
Comment 9 Commit Notification 2022-05-24 07:55:34 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/55557e6cfb828dccb0af56d4886af73a5b46f052

tdf#148168 set built-in gtk search box to search "document name" column

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-05-24 18:41:16 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b0ba3ed1992b24c8808604553278fe75b093c0a9

Resolves: tdf#148168 disable gtk treeview seach box

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-05-31 14:15:20 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/48adb09c2032285bc7d02f495cbdb3fc5185f0c5

tdf#148168 set built-in gtk search box to search "document name" column

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.