Bug 148248 - Autofilter menu item label "Text Color" is better to be "Font Color"
Summary: Autofilter menu item label "Text Color" is better to be "Font Color"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: target:7.5.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks:
 
Reported: 2022-03-29 12:43 UTC by Shinji Enoki
Modified: 2022-07-15 09:40 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Menu item label of Autofilter (69.35 KB, image/jpeg)
2022-03-29 12:51 UTC, Shinji Enoki 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinji Enoki 2022-03-29 12:43:06 UTC 
Description:
It may be better to change the Autofilter menu item label "Text Color" to "Font Color"
Many dialog or buttons use "Font Color" than "Text Color". 
I think different label for same functions is not easy understand. This is usability issue.

Steps to Reproduce:
1.Start Calc and create Autofilter
2.Click filter on the cell
3.Click "Filter by Color"
You can check label "Text Color".

This filter is color of "Font Color" function,  such as "Font Color" button in "Formatting toolbar". 

Or "Font color" setting view is in "Font Effects" tab of "Format Cells" dialog.


Actual Results:
"Text Color".

Expected Results:
"Font Color"


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: e8c95b796626cb9db163f5d563fa67f38a5e92b0
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: en-US
Calc: threaded
Comment 1 Shinji Enoki 2022-03-29 12:51:17 UTC 
Created attachment 179185 [details]
Menu item label of Autofilter
Comment 2 JO3EMC 2022-03-29 13:11:52 UTC 
I agree.

I think it's confusing to have a mixture of the two terms.
Comment 3 JO3EMC 2022-04-06 10:36:58 UTC 
I don't understand it so far, but are you consciously using them properly?
If anyone knows, could you please tell me?
Comment 4 Heiko Tietze 2022-04-25 15:47:57 UTC 
It's a bit unclear in case of View > Value Highlighting. Samuel, was it a deliberate choice?
Comment 5 Joselp 2022-04-25 16:00:35 UTC 
I don't understand where the problem lies....

The filter makes it clear if you want to filter by text colour or background colour, but if it is because of inconsistencies in the interface, it would be correct to unify concepts.
Comment 6 Gabor Kelemen (allotropia) 2022-04-25 16:16:01 UTC 
Just checked my Excel 2013, they also call it "Filter by Font Color".
+1 to change this.
Comment 7 Heiko Tietze 2022-04-26 08:20:34 UTC 
Got green light from Samuel. Let's do it.

Code pointer: sc/inc/strings.hrc SCSTR_FILTER_TEXT_COLOR and SCSTR_FILTER_TEXT_COLOR_COND
Comment 8 JO3EMC 2022-04-26 13:13:49 UTC 
Thank you for your discussion.
Comment 9 Gabor Kelemen (allotropia) 2022-07-14 17:10:40 UTC 
Proposed patch: https://gerrit.libreoffice.org/c/core/+/137087
Comment 10 Commit Notification 2022-07-15 08:30:54 UTC 
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/126067992d7a2b3edc5dd6ce5e896343da537589

tdf#148248 Text Color -> Font Color in AutoFilter/Standard Filter

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Gabor Kelemen (allotropia) 2022-07-15 09:40:45 UTC 
No intention to backport to 7-4, we are past string freeze.