Description: There's places in code where a swap between two variables happens like this: T temp = a; a = b; b = temp; There's no need to clutter code with 3 lines where just one is enough: std::swap(a, b); Furthermore, std::swap uses move semantics which can improve performance for big data members. How to find occurrences: You can use this regex that currently finds 78 results: (\w+)[\n\r\s]+(\w+)[\n\r\s]+=[\n\r\s]+(\w+);[\n\r\s]+(\3)[\n\r\s]+=[\n\r\s]+(\w+);[\n\r\s]+(\5)[\n\r\s]+=[\n\r\s]+(\2) [\n\r\s]+ matches newlines and spaces. This exhaustively searches for any weird combination of spaces between the type/variable names/semicolons See this https://gerrit.libreoffice.org/c/core/+/132194 for an example Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: -
Set to NEW