Bug 148384 - "Sending Email messages" dialog does not stay open upon errors
Summary: "Sending Email messages" dialog does not stay open upon errors
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.4.0 target:7.3.3
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: Mail-Merge
  Show dependency treegraph
 
Reported: 2022-04-05 07:58 UTC by Mike Kaganski
Modified: 2022-04-27 14:46 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Compare results in 5.1 vs current master (37.55 KB, image/png)
2022-04-05 08:14 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-04-05 07:58:02 UTC
1. Create a SCV for mail merge address list:

email,name
foo1,foo1
foo2,foo2

2. Create a new Writer document, start Tools->Mail Merge Wizard, and assign the created CSV as the address list.

3. Click "Send Email Messages" button on the Mail Merge toolbar. Make sure that "email" is selected in "To" field, and press "Send Documents" button.

The process starts, showing progress of generating documents, then "Sending Email messages" dialog opens, showing progress of delivery, and *it is closed automatically after the process*, despite there were errors (the emails were invalid), which were indicated in the "Emails not sent" field of the dialog while it was still open.

This is a regression since 5.2, where the Mail Merge wizard dialog was restructured. Before that, the results were kept open, so user could inspect the failed entries.
Comment 1 Mike Kaganski 2022-04-05 08:00:22 UTC
https://gerrit.libreoffice.org/c/core/+/132563
Comment 2 Mike Kaganski 2022-04-05 08:14:20 UTC
Created attachment 179314 [details]
Compare results in 5.1 vs current master

The change mentioned in comment 1 reveals that the results are currently broken: task names (like "sending to: email@address") are not shown.
Comment 3 Commit Notification 2022-04-05 15:02:30 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2d9f12be1530f2532276a2447102ed2f1f0ecb5b

tdf#148384: Really leave mail merge results dialog open upon errors

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-04-05 15:02:38 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/64b046b908cdf1204b105f1ebddfc41a5054e884

Related tdf#148384: Don't overwrite task name with result

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-04-05 15:03:47 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/abaa11329822d659581d7860a82308409189f0f5

Related tdf#148384: Improve mail merge results reporting

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Timur 2022-04-05 17:14:17 UTC
(In reply to Mike Kaganski from comment #0)
> 1. Create a SCV for mail merge address list:
> 
> email,name
> foo1,foo1
> foo2,foo2

In order to make this easier I proposed bug 140885. Please see. 

As for this one, I remember seeing someone complain but I couldn't find now.
Comment 7 Mike Kaganski 2022-04-05 18:34:01 UTC
(In reply to Timur from comment #6)
> In order to make this easier I proposed bug 140885. Please see. 

Nice! I wonder if it's possible to do using an extension ...
Comment 8 Commit Notification 2022-04-05 20:51:32 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6453502fa8d3cc83e066c550d8df98facb1f4471

Related tdf#148384: do not pause after last email's failure

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-04-06 08:34:09 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/ac165ad008d820dc102f98569f8bb9b6653b852d

tdf#148384: Really leave mail merge results dialog open upon errors

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-04-06 15:41:21 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/f02673722dc14c9f1864887d5b159cda0d7ae8c4

Related tdf#148384: Don't overwrite task name with result

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-04-11 02:01:24 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/8e467c88d0ba6e70159382676af55b8ef8d65d54

Related tdf#148384: do not pause after last email's failure

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.