Bug 148635 - Deselecting a chart after insertion being slow
Summary: Deselecting a chart after insertion being slow
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.5.0 target:7.4....
Keywords: perf
Depends on:
Blocks: Chart
  Show dependency treegraph
 
Reported: 2022-04-17 09:36 UTC by Telesto
Modified: 2025-05-10 03:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (14.46 MB, application/vnd.oasis.opendocument.spreadsheet)
2022-04-17 09:36 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-04-17 09:36:11 UTC
Description:
Deselecting a chart after insertion being slow

Steps to Reproduce:
1. Open the attached file
2. Select column C
3. Press insert chart (chart appears pretty fast)
4. Click Finish the dialog
5. Click somewhere in the spreadsheet -> waiting 12 seconds

6. Reselect the chart
7. Press delete -> Wait 10 seconds

Actual Results:
Freeze for 12 seconds

Expected Results:
I kind of expected no freeze


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4659fc2f0a7223a89446edff0b77e58758b5edf5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL Jumbo
Comment 1 Telesto 2022-04-17 09:36:34 UTC
Created attachment 179623 [details]
Example file
Comment 2 Telesto 2022-04-17 09:40:09 UTC
@Noel,
Adding you to the loop in advance (no confirmation, yet), because you're work in this area (and being and optimization specialist)
Comment 3 Commit Notification 2022-04-19 16:13:22 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6500106dff0f0cd86f509ffd01542aab77c21596

tdf#148635 no need to init ChartDataWrapper more than once

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-04-19 16:14:31 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fd2ca9607431fc6ca49e37ab6fef228aa72da5f9

tdf#148635 cache some chart stuff

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-09-22 19:00:57 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c3bc67bffd1e0b9bdd60ef274a6d5e59101d322d

tdf#151091 Revert "tdf#148635 cache some chart stuff"

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-09-23 09:35:05 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/a81b6299deca88a61fe4d8c5909c02375c9f8620

tdf#151091 Revert "tdf#148635 cache some chart stuff"

It will be available in 7.4.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-09-23 10:38:06 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4-2":

https://git.libreoffice.org/core/commit/3f0be840432453f407751398ccfab62a2243fc4e

tdf#151091 Revert "tdf#148635 cache some chart stuff"

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Gabor Kelemen (allotropia) 2023-05-10 07:12:26 UTC
(In reply to Commit Notification from comment #3)
> Noel Grandin committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> 6500106dff0f0cd86f509ffd01542aab77c21596
> 
> tdf#148635 no need to init ChartDataWrapper more than once
> 
> It will be available in 7.4.0.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

This was reverted due to bug 155210 

https://cgit.freedesktop.org/libreoffice/core/commit/?id=40f5a5be9fd228a5d33a3b1218864a38cb70dc1f
Comment 9 QA Administrators 2025-05-10 03:11:33 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug