Bug 148675 - Table grid lines are black on black in document Dark mode
Summary: Table grid lines are black on black in document Dark mode
Status: NEEDINFO
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.2.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: UI-Theming
  Show dependency treegraph
 
Reported: 2022-04-19 18:00 UTC by lostbits
Modified: 2022-09-29 11:47 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lostbits 2022-04-19 18:00:18 UTC
Description:
Grid lines are difficult to see in dark mode, and can only be seen if the background is light enough to see the black grid lines.

Steps to Reproduce:
1.Change to dark mode (Tools->Options->Appearance Colors->Libre Office Dark)
2.Create a table (table->insert table) with multiple cells
3.Observe the appearance

Actual Results:
Table grid lines are black and can only be seen if the background is a lighter color.

Expected Results:
Table grid lines would be a much lighter color than the background (white, yellow, etc.) and visible.
Several proposals are made [enhancements]?
1. Automatically adjust colors on switching modes.
2. Provide an option in Tools->Options->Appearance Colors to allow grid color switching (Table Boundaries and Spreadsheet Grid do not work).

As a note, Table->Properties->Borders->Color allows colors to be displayed but this alters the output colors, and must be done on each table on a table-by-table basis.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

Unable to copy Help->About Libre Office
Build: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
Comment 1 Timur 2022-04-20 17:31:12 UTC Comment hidden (obsolete)
Comment 2 Rafael Lima 2022-06-18 13:43:28 UTC
Confirmed with

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: ca47989ad60b1414f92be22a1fbf4c1d1a92dd97
CPU threads: 12; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL

Border colors do not have an "Automatic" color option, so I'm not sure how we will be able to handle dark borders in Dark mode.

Text in tables are shown in white when using dark mode, so we should have the same behavior for table borders.
Comment 3 Rafael Lima 2022-06-18 13:46:11 UTC
(In reply to Timur from comment #1)
> Please see if related to
> https://bugs.documentfoundation.org/show_bug.cgi?id=118320#c91

This bug is not Windows-only. It happens on Linux as well.

I could not find a Windows Dark-Mode meta bug, so I'm adding the one you mentioned as a "See Also" bug.
Comment 4 Pedro 2022-06-19 15:16:55 UTC
This is related to the LibreOffice dark color scheme. Not the UI dark theme from bug #118320
Comment 5 Timur 2022-09-12 15:32:29 UTC
(In reply to lostbits from comment #0)
> Several proposals are made [enhancements]?
> 1. Automatically adjust colors on switching modes.
> 2. Provide an option in Tools->Options->Appearance Colors to allow grid
> color switching (Table Boundaries and Spreadsheet Grid do not work).

I do not understand how Table Boundaries do not work. Changed in Options, they work for me. 
Only bug I see is that default value is preset to dark, instead of light color.
Comment 6 Timur 2022-09-13 06:53:29 UTC Comment hidden (obsolete)
Comment 7 Rafael Lima 2022-09-13 14:34:08 UTC
(In reply to Timur from comment #6)
> Needinfo for explanation.

Hi Timur,

I changed Table Boundaries to light-gray and the table is still being inserted using black borders. FTR I restarted LO after changing the color settings but table borders are still black.

System info

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 641d92a73e5b3d0e062e16ed4b42236e1a4796a5
CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: threaded
Comment 8 Timur 2022-09-13 14:56:17 UTC
No repro in Windows, as initial reporter. But also not in Linux without dark mode.
Rafael, did you also not have dark mode, or it's mixed up?
Comment 9 Rafael Lima 2022-09-13 18:20:13 UTC
(In reply to Timur from comment #8)
> Rafael, did you also not have dark mode, or it's mixed up?

I am using KDE with stock Breeze Dark theme.

In LibreOffice I just switched to the "LibreOffice Dark" color scheme (under Application Colors) and changed the "Table boundaries" color to "Light gray 5". Still table borders are appearing black to me.
Comment 10 lostbits 2022-09-13 20:43:04 UTC
Win11-64
LO 7.3.2
Build 9f2b1bff42cfccbd8f788c8dc32c1c309559be0

Cell boundary colors remain black under any theme, making them invisible in dark themes.

1. There is no way to change the boundary colors in tools->options->Application Colrs.
2. Changing Cell boundary colors in Table->Table Properties->Line->color changes the cell boundary colors as previously mentioned.
3. The printed cell boundary color matches the changed cell boundary color. This means that in order to print where the output paper background color is, eg, white, each table has to be modified. This means that:
   a. In order to see cell boundaries in a dark theme, each table must be modified.
   b. In order to print black cell boundary colors on output, each table must be modified.

Effectively there are two burdens, to see the boundaries while creating a document and to output the boundaries when printing a document. 

The color issue (I believe) exists for all Application Colors, the color scheme selected during edit is the color scheme eventually printed, and perhaps, exported as a PDF. Is there any way to change this behavior? In some cases I can create two styles, one for editing and one for printing/exporting. Before output I can change the style to get the desired result. But it's a real pain.
Comment 11 Timur 2022-09-14 15:06:12 UTC
Let me try to make a summary:
- lostbits is Windows 11, doesn't say if OS dark mode so let's guess not, using Application Colors->Scheme: Libre Office Dark, cannot use Table Boundaries

- Rafael is Linux KDE, OS Breeze Dark theme (giving dark menus), plus Appearance Colors->Scheme: Libre Office Dark (giving dark document background), Application Colors->Table boundaries change doesn't work

- Timur tested Windows, no OS dark mode, Application Colors->Scheme: Libre Office Dark, can use Table Boundaries to set light color table borders

- Timur tested Linux GTK3/KF5, OS dark theme (giving dark menus to LO),  Scheme: Libre Office Dark, can use Table Boundaries to set light color table borders directly or Automatic

So, problem here is that you cannot set Table Boundaries, not clear why. 
Please make a screencast how you cannot change that, both setting let's say yellow and Automatic.
Comment 12 Timur 2022-09-29 11:47:41 UTC
Needinfo for a screencast.