Bug 148702 - In Arrow Styles tab of Line dialog, place Arrow Styles control first (before "title" control)
Summary: In Arrow Styles tab of Line dialog, place Arrow Styles control first (before ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Akshay Warrier
URL:
Whiteboard: target:24.8.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks: Arrow_Style
  Show dependency treegraph
 
Reported: 2022-04-21 07:51 UTC by sdc.blanco
Modified: 2024-01-22 13:35 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-21 07:51:59 UTC
Consider placing ”dropdown box” (Arrow style) first, before Style name (title)  control – because the dropdown box selects which style is going to be ”Rename”d or ”Delete"d.    

iow, the dropdown box is often the first action to be done on the tab, so it should give the right affordance to have it placed  first.

(Meanwhile,  the dropdown box and Style name are not relevant to ”Add” because another dialog box pops up to give the Style name, so a change in ordering would not matter in this case.)
Comment 1 Heiko Tietze 2022-04-21 08:35:29 UTC
Little benefit, IMO. We better remove the field and have the rename functionality in an extra dialog; Modify asks for a new name so it shouldn't be a big deal.
Comment 2 sdc.blanco 2022-04-21 10:12:12 UTC
(In reply to Heiko Tietze from comment #1)
> Little benefit, IMO. 
I agree.  Mostly "polish", but from using the dialog a lot, it started to make more sense to have the dropdown box first.

> We better remove the field and have the rename
> functionality in an extra dialog; Modify asks for a new name so it shouldn't
> be a big deal.
That would work as well.  But fwiw, the present design makes it easy/convenient to change the name of the style in one step (i.e., can edit the name directly and click on Modify (rename), while this proposal requires 2 steps (click Modify, edit name in popup box, click ok).

In either case, maybe this is an EasyHack?
Comment 3 Heiko Tietze 2022-04-21 10:35:02 UTC
The arrangement of controls is very simple and suited for non-developers. Having rename on click requires basic c++ knowledge.

Code pointer: 

* cui/uiconfig/ui/lineendstabpage.ui
* cui/source/tabpages/tplneend.cxx
Comment 4 Commit Notification 2024-01-22 13:35:38 UTC
AkshayWarrier committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e531242f62d27000ab5fefd6d63023d4a1060c75

tdf#148702 cui: Place dropdown before entry in Arrow Styles tab of Line dialog

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.