Bug 148714 - shapes of type "curved*Arrow" use wrong commands in segments definition
Summary: shapes of type "curved*Arrow" use wrong commands in segments definition
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:7.4.0 target:7.3.4
Keywords:
Depends on:
Blocks: 148707
  Show dependency treegraph
 
Reported: 2022-04-21 19:24 UTC by Regina Henschel
Modified: 2022-05-03 18:14 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Problematic shapes and a description of the problem (35.72 KB, application/vnd.oasis.opendocument.presentation)
2022-04-21 19:24 UTC, Regina Henschel
Details
ppt version of the curved*Arrow shapes (52.00 KB, application/vnd.ms-powerpoint)
2022-04-22 13:49 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2022-04-21 19:24:21 UTC
Created attachment 179715 [details]
Problematic shapes and a description of the problem

The attached document contains on the first slide the shapes "curvedDownArrow", "curvedUpArrow", "curvedRightArrow" and "CurvedLeftArrow". These shapes are available in binary MS Office and here import from a ppt file.

Open the document in PowerPoint or Scribus, for example. They show, what LO is actually writing to file. The rendering in LO does not reflect this because of bug 148707.
The geometry for these shapes need to be repaired, before bug 148707 can be fixed.
Comment 1 Regina Henschel 2022-04-22 13:49:38 UTC
Created attachment 179728 [details]
ppt version of the curved*Arrow shapes
Comment 2 Commit Notification 2022-04-29 05:28:30 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4cfe46997eab3498cc519ef94c85ad2d644d3886

tdf#148714 connect first and second arc with arcTo

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2022-05-02 13:56:53 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/fdf4390415a6956144d055a32579105deaef913a

tdf#148714 connect first and second arc with arcTo

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-05-03 16:55:50 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8ad4fdb1687e705e31d9a4f30b385d50b91def08

tdf#148714 Repair path in older CurvedArrow shapes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Regina Henschel 2022-05-03 18:14:31 UTC
Because nobody answered to my post on the dev-list, I made a decision and have implemented a repair of those shapes on opening an old document. Reasons for this are:
When bug 148707 is fixed, an old shape would look different than before and a user would not know why, if the shape is not repaired.
Without repair the shapes would be wrong in pptx export. Using an ooxml shape on export to pptx or docx instead does not really work. The geometry looks equal, but the text areas are different, so text on the shape will wrap differently.
Repairing needs only to be done once and a repaired shape will render still correctly in old LO versions.