Bug 148718 - Ambiguous use of Chapter in Table of Contents, Index of Bibliography dialog
Summary: Ambiguous use of Chapter in Table of Contents, Index of Bibliography dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: low enhancement
Assignee: sdc.blanco
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks:
 
Reported: 2022-04-22 08:23 UTC by Mike Kaganski
Modified: 2023-02-12 01:39 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
ToC dialog screenshot (31.75 KB, image/png)
2022-04-22 08:23 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-04-22 08:23:49 UTC
Created attachment 179721 [details]
ToC dialog screenshot

Look at the screenshot. There is the "Create Index or Table of Contents For" choice includes a "Chapter" selection - which means to create an index *only below current outline 1 section* - making "Chapter" term to mean exactly "part of text starting from a paragraph having outline 1 level, up to (excluding) the next outline 1 paragraph".

On the same dialog, see the "preview" image at the right; it mentions "first chapter", "chapter 1.1", "chapter 1.2". This immediately makes it confusing, not clear what "chapter" might relate to at all - people would not see that the "for Chapter" choice mentioned above will not consider any outline level as a "chapter".

The preview must not use "chapter" for 1.x; it may use other terms like "section" (although having special meaning in Writer in general, but clear in the context of the dialog, and not confusing users).
Comment 1 Mike Kaganski 2022-04-22 08:27:34 UTC
(In reply to Mike Kaganski from comment #0)
> The preview must not use "chapter" for 1.x; it may use other terms like
> "section"

Or maybe "sub-chapter". But in any case, not "chapter".
Comment 2 Timur 2022-04-27 08:49:18 UTC
Seems clear to me. Really it may be "Chapter or sub-chapter".
Comment 3 Heiko Tietze 2022-04-27 10:40:17 UTC
The preview uses "Heading", which is mistakenly used across the application. Chapter and Subchapter, for the issue here, seems to be the better choice.

Easy hackable, code pointer:

sw/inc/strings.hrc -> STR_IDXEXAMPLE_IDXTXT_HEADING1 ff.

Seth, one for you?
Comment 4 Commit Notification 2022-04-27 16:48:08 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6fbc3de17cd9274dc3a09e1eeb914c45f7dfe140

tdf#148718  Heading -> Chapter in Index preview

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Mike Kaganski 2022-04-28 06:12:10 UTC
(In reply to Heiko Tietze from comment #3)
> The preview uses "Heading", which is mistakenly used across the application.
> Chapter and Subchapter, for the issue here, seems to be the better choice.

Sigh. The bug had been so clear and precise on what was wrong - why would anyone mention "Headings" in this context? Headings were used *correctly* here, meaning paragraphs having an outline level. The commit mentioned in comment 4 had implemented the (incorrectly) expanded proposal, and now needs to be partially reverted.

Only "content from chapter 1.1" and "content from chapter 1.2" needed to be re-worded as "content from subchapter 1.1" and "content from subchapter 1.1", respectively.
Comment 6 Commit Notification 2022-04-30 07:51:34 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cc7732fb4bbe8ffd6820c4db559d326c043bfb67

tdf#148718 Partial revert of commit 6fbc3de17cd9274dc3a09e1eeb914c45f7dfe140

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.