Bug 148732 - UI: Default Character in Format Styles is called No Character Style in character styles deck of the sidebar
Summary: UI: Default Character in Format Styles is called No Character Style in charac...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: sdc.blanco
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Writer-Styles-Character
  Show dependency treegraph
 
Reported: 2022-04-22 18:26 UTC by Telesto
Modified: 2022-04-26 21:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-04-22 18:26:25 UTC
Description:
Default Character in Format Styles is called No Character Style in character styles deck of the sidebar

Steps to Reproduce:
1. Open Writer
2. Type some text: Hello World
3. Select Hello World
4. Styles (menu bar) -> Emphasis and back to Default Character Style
5. Sidebar -> Styles Deck -> Character Styles -> Calls it No Character Style

Actual Results:
Styles in Menubar calles it 'Default Character Style"

Expected Results:
It should be No Character Style I guess


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4659fc2f0a7223a89446edff0b77e58758b5edf5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Heiko Tietze 2022-04-25 09:55:38 UTC
"Default CS" was renamed "No CS" for bug 140818 and this command was obviously missed.

The label for .uno:DefaultCharStyle is defined in officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu

Seth, one for you?
Comment 2 sdc.blanco 2022-04-25 23:04:11 UTC
https://gerrit.libreoffice.org/c/core/+/133401

Seeking feedback on tooltip, which would appear (a) in the customize dialog and (b) over the "A" icon in the Formatting (Styles) bar.

Hard to formulate because it sometimes describes a state (no CS) and sometimes a process (removing CS). I chose to emphasize the process, rather than try to express the dual nature.
Comment 3 Heiko Tietze 2022-04-26 07:33:56 UTC
Sounds good to me, easy to understand and focusing on laymen users.
Comment 4 sdc.blanco 2022-04-26 21:37:23 UTC
(In reply to Heiko Tietze from comment #3)
> Sounds good to me, easy to understand and focusing on laymen users.
Ok.  But today I saw bug 148790 (concerned about "No List" being highlighted when cursor in non-list paras). It is a similar situation here. "No Character Style" icon will be highlighted (i.e., state), while showing a (process) tooltip explaining that the command can be used to remove character styles (which are being indicated as removed).

But let's try and see what happens. (at least the tooltip will be more meaningful  in the Customize dialog).
Comment 5 Commit Notification 2022-04-26 21:38:47 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bc79e5fcde5d6ad07d75e2a02c8e164c45e0f02a

tdf#148732  Change label, add tooltip for .uno:DefaultCharStyle

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.