Bug 148751 - [UI] Text toolbar is not in View - Toolbar menu and cannot be displayed
Summary: [UI] Text toolbar is not in View - Toolbar menu and cannot be displayed
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:7.4.0
Keywords: needUITest
Depends on:
Blocks:
 
Reported: 2022-04-24 09:59 UTC by Olivier Hallot
Modified: 2022-04-29 12:47 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2022-04-24 09:59:45 UTC
The 'Text' toolbar can be seen in the Tools - Customize - Toolbars but is not displayed in the View - Toolbars menu of Draw

So the user interface cannot select this toolbar for display, at least in by an average user.

Code pointer: .uno:AvailableToolbars
Comment 1 flywire 2022-04-24 10:25:28 UTC
Text toolbar not available in Writer either.

Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-AU (en_AU); UI: en-GB
Calc: threaded
Comment 2 Rafael Lima 2022-04-25 11:23:11 UTC
The reason why this toolbar is hidden is because its property "HideFromToolbarMenu" is set to True in DrawWindowState.xcu. Changing this property to false will show the toolbar again.

See https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu?r=4f756024#618

This bug is very simple to fix... however I wonder if there's any special reason why this toolbar was explicitly hidden from the tool bar.
Comment 3 Rafael Lima 2022-04-25 13:02:17 UTC
Proposed patch at:
https://gerrit.libreoffice.org/c/core/+/133395
Comment 4 Heiko Tietze 2022-04-25 15:36:25 UTC
It was set to hidden 17 years ago in https://github.com/LibreOffice/core/commit/bd413523b0531838505be3718b8cc6b9e10afef5
Comment 5 Commit Notification 2022-04-26 10:06:56 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0aaa964224be38323e4f9e456655da2a8b4c2b66

tdf#148751 Enable Text toolbar by default in Draw

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.